Add param for settings that require mission restart #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dystopian
reviewed
Aug 9, 2018
| true | ||
| true, | ||
| {[QGVAR(enabled), _this] call EFUNC(common,cbaSettings_settingChanged)}, | ||
| true // Needs mission restart |
There was a problem hiding this comment.
this comment looks quite weird in each file because other params are not commented
There was a problem hiding this comment.
TBH I would prefer the other true's to be commented too. But on the other end we cannot comment the same things over and over again everywhere.
Or better we probably shouldn't.
jonpas
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref CBATeam/CBA_A3#894
Use the new cba_settings_init param to mark settings as requiring restart
For converted settings the logic is just any global setting
there are some global settings that can be changed mid-mission, and we could think about it when converting.