-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent treatment animation on dead bodies #6524
Conversation
This was causing bodies to glitch out on dedicated servers according to feedback
@@ -69,7 +69,7 @@ if (IS_UNCONSCIOUS(_target) && EGVAR(medical,allowUnconsciousAnimationOnTreatmen | |||
|
|||
private _isSelf = _caller isEqualTo _target; | |||
|
|||
if (!_isSelf && {vehicle _target == _target} && {_patientAnim != ""}) then { | |||
if (!_isSelf && {vehicle _target == _target} && {_patientAnim != ""} && {alive _target}) then { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably do an isAwake
check instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May only apply to actually dead bodies, not ragdolls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but otherwise it becomes another easy way to tell if a unit is not alive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I've never actually noticed treatment animations before 😄 Maybe that means they're doing their job though
I'm in favour of an isAwake check 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Treatment animations have always been disabled by default iirc. Due to some very valid reasons documented in a pr way back. Or maybe just slack?
Since we're now using an isAwake check the unconscious treatment animation setting is now obsolete (I suggested it for removal here), do you want me to remove that in this PR also? |
@SilentSpike separate PR I think. All changes in this PR now look good. edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Prevent treatment animation on dead bodies This was causing bodies to glitch out on dedicated servers according to feedback * Remove patient animation logic and setting
This was causing bodies to glitch out on dedicated servers according to feedback.