Make state change status updates consistent #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State transitions call respective functions in the status component where unit variables and status are actually handled.
kymckay
added
kind/cleanup
TheMagnetar
requested changes
Aug 22, 2018
| @@ -1,7 +1,8 @@ | |||
| #include "script_component.hpp" | |||
| /* | |||
| * Author: BaerMitUmlaut | |||
| * Handles a unit entering cardiac arrest. | |||
| * Author: RedBery | |||
There was a problem hiding this comment.
Author: BaerMitUmlaut, RedBery
There was a problem hiding this comment.
Baer's name was only here because the enteredStateCardiacArrest file was copied over and edited so the header was for that function.
TheMagnetar
approved these changes
Aug 22, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
State transitions call respective functions in the status component where unit variables and status are actually handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State transitions now call their respective status update functions in the status component where unit variables and status are actually handled.
We don't actually need to use events here since the statemachine component depends on the status component. For public consumption we already raise an
ace_unconsciousandace_cardiacArrestevent within the status update functions (the latter I changed to make consistent with existing unconscious event so it fires for both entry and exit).This PR also fixes an additional behaviour where on death a unit would become bloodied even if they weren't before (untested, but going by the
setStructuralDamagefunction header that's what it's for).I've also taken the chance to rename the
setUnconsciousStatemachinefunction to simplysetUnconscioussince it resides in the status component and thus has the prefix to differentiate it from the publicace_medical_fnc_setUnconscious.Closes #6531