RHS Compat - Fix GREF canoes refuel interaction #6575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Sep 15, 2018
| @@ -6,8 +6,9 @@ class CfgPatches { | |||
| units[] = {}; | |||
| weapons[] = {}; | |||
| requiredVersion = REQUIRED_VERSION; | |||
| requiredAddons[] = {"rhsgref_main", "rhsgref_c_weapons"}; | |||
| requiredAddons[] = {"ace_refuel", "rhsgref_main", "rhsgref_c_weapons"}; | |||
There was a problem hiding this comment.
don't want ace_refuel here as we want to keep it optional/modular
mharis001
reviewed
Sep 15, 2018
| class Ship_F: Ship {}; | ||
| class Boat_F: Ship_F {}; | ||
| class Rubber_duck_base_F: Boat_F {}; | ||
| class rhsgref_canoe_base: Rubber_duck_base_F { |
There was a problem hiding this comment.
Just need the parent class of this.
PabstMirror
approved these changes
Sep 15, 2018
PabstMirror
changed the title
Grey-Soldierman
pushed a commit
to Grey-Soldierman/ACE3
that referenced
this pull request
Sep 18, 2018
* Fix RHS GREF canoes refuel interaction * Removed ace_refuel from requiredAddons * fix inheritance
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Fix RHS GREF canoes refuel interaction * Removed ace_refuel from requiredAddons * fix inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: