Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realisticnames - Update AMS and KHS's name #6605

Merged
merged 4 commits into from
Oct 13, 2018
Merged

Realisticnames - Update AMS and KHS's name #6605

merged 4 commits into from
Oct 13, 2018

Conversation

Laid3acK
Copy link
Contributor

@Laid3acK Laid3acK commented Sep 29, 2018

When merged this pull request will:

Add the real name to these two scopes :

As usual, the 3D models don't match exactly with the real scopes, only with the 2035 ones.

<Japanese>US Optics MR-10 (Sand)</Japanese>
</Key>
<Key ID="STR_ACE_RealisticNames_optic_khs_blk">
<English>KALHES Helia (Black)</English>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: KAHLES

@Laid3acK
Copy link
Contributor Author

Too much wine yesterday ... Thanks.

@PabstMirror PabstMirror added this to the 3.13.0 milestone Oct 13, 2018
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 13, 2018
@PabstMirror PabstMirror changed the title AMS and KHS realistic name Realisticnames - Update AMS and KHS's name Oct 13, 2018
@PabstMirror PabstMirror merged commit 6363f73 into acemod:master Oct 13, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
Realisticnames - Update AMS and KHS's name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants