Split interaction menu settings between interaction and self interaction #6609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dystopian
reviewed
Oct 2, 2018
Dystopian
reviewed
Oct 2, 2018
Dystopian
reviewed
Oct 2, 2018
added 2 commits
October 2, 2018 00:34
not sure which way is wanted here, but I might as well be consistent in my own PR
Dystopian
reviewed
Oct 2, 2018
dedmen
reviewed
Oct 2, 2018
dedmen
approved these changes
Oct 2, 2018
Dystopian
reviewed
Oct 3, 2018
|
Is there anything outstanding I need to do on this PR? It should it is good for a full review. |
TheMagnetar
requested changes
Mar 18, 2019
added 2 commits
March 18, 2019 10:58
TheMagnetar
approved these changes
Mar 19, 2019
jonpas
previously requested changes
Dec 7, 2019
|
I changed the default of cursorKeepCenteredSelfInteraction to false (how it was before) |
Might be fixed soon:tm:, thanks to @dedmen |
|
This merge broke #7381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
This is something that's always annoyed me about self interaction, so I figured I'd finally do something about it. Pretty minor but personally not seeing people wave their guns in the air as they navigate self interaction is a decent improvement.
Edit note: By default both backgrounds are set to disabled, my personal setting is the blur screen.