Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Mount - Fix turrets without weapon treated as gunner #6636

Merged

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • title.

Some vehicles have turrets without weapons. They should be treated as cargo not gunners because they can influence (Quick)mount order.
Vanilla vehicles: B_T_VTOL_01_infantry_F, B_T_VTOL_01_vehicle_F (passengers in cabin).
There are some vehicles in RHS and quite many in CUP. Especially CUP SUVs (like CUP_I_SUV_Armored_ION) where you first get in external cargo seats on SUV sides.

@@ -93,7 +97,7 @@ if (!isNull _target &&
{
if ((_x select 2) == _cargoIndex) exitWith {_cargoActionIndex = _forEachIndex};
} forEach (fullCrew [_target, "cargo", true]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a findIf ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 yeah but out of this PR scope 👅

@PabstMirror PabstMirror added this to the 3.13.0 milestone Oct 12, 2018
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 12, 2018
@PabstMirror PabstMirror self-assigned this Oct 12, 2018
@PabstMirror PabstMirror merged commit 4ff8fc1 into acemod:master Oct 13, 2018
@Dystopian Dystopian deleted the fix_quickmount_not_armed_turrets branch October 13, 2018 21:50
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants