Safe Mode - Fix disabled laser on safety switch

[Dystopian]

When merged this pull request will:

• title.

[Dystopian]

It works when you switch safety with hotkey. It doesn't work when safety is turned off with weapon mode key (related to #210).

[commy2]

Pretty sure this breaks something else. UGL muzzles?

[Dystopian]

On my PC safety doen't correctly work with UGL before patch too. I don't know about anything else.

[alganthe]

Bare my comments above, this has a core issue, GunLightOn and IRLaserOn switches you to your primary, there is currently no way to toggle flashlights and IR lasers for players that doesn't have an issue.

[commy2]

Finally someone gets it.

[Dystopian]

I already met this bug in

ACE3/addons/common/functions/fnc_switchPersistentLaser.sqf

Line 51 in 52abed1

|| {_weaponIndex > 0 && {"" != primaryWeapon _player}} // Arma switches to primary weapon if exists

should add workaround here too.

[PabstMirror]

I think this should be bellow the action [SwitchWeapon

[PabstMirror]

MX-GL with modes [single, auto, gl]

Single:
Safe on -> Safe off with keybind: laser on, in semi
Safe on -> Safe off with F (next weapon): laser on, in auto
Auto:
Safe on -> Safe off with keybind: laser on, in semi
Safe on -> Safe off with F (next weapon): laser disabled, in auto
GL:
Safe on: laser disabled
restart laser
Safe off with keybind: laser disabled, in GL
Safe off with F (next weapon): laser disabled, in auto

This PR is an improvement over current, so I'd say we merge and fix it later.

Notes for me:
I think the problem is in the addActionEventHandler and the weapon swap happens before we think it should. So the currentMuzzle changes first and then the eh runs when we check inputAction.
Also, I can't see any reason why we are doing selectWeapon in fnc_lockSaftey

private _modes = [];
private _weaponCfg = configFile >> "CfgWeapons" >> _weapon;
{
    private _muzzle = _x;
    private _muzzleCfg = _weaponCfg;
    if (_x == "this") then {
        _muzzle = _weapon;
    } else {
        _muzzleCfg = _muzzleCfg >> _x;
    };
    {
        if (getNumber (configFile >> "CfgWeapons" >> _weapon >> _x >> "showToPlayer") == 1) then {
            _modes pushBack [_muzzle, _x];
        };
        if (_x == "this") then {
            _modes pushBack [_muzzle, _weapon];;
        };
    } forEach getArray (_muzzleCfg >> "modes");
} forEach getArray (_weaponCfg >> "muzzles");


// _previousModeIndex = (_modes find [currentMuzzle, currentMode]) - 1
// (_modes select _targetModeIndex) params [["_targetMuzzle", "#"], ["_targetMode", "#"]];

[PabstMirror]

Merging for 3.12.6
We can continue to improve later

"the sidearm issue is fixed"