AI - Fix units not being removed from the garrison unitMove list consistently #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how I missed that.
dedmen
reviewed
Oct 23, 2018
| }; | ||
|
|
||
| if ({(_x getVariable [QGVAR(garrisonned), false]) && !isPlayer _x} count (units _x) == 0) then { | ||
| if ({(_unit getVariable [QGVAR(garrisonned), false]) && !isPlayer _unit} count (units _unit) == 0) then { |
There was a problem hiding this comment.
count == 0 could be a findIf == -1 instead.
dedmen saw nothing :D
PabstMirror
changed the title
PabstMirror
approved these changes
Oct 24, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
…istently (#6651) * Fix units not being removed from the garrison unitMove list consistently Not sure how I missed that. * fix whitespace * Fix typo in unGarrison check dedmen saw nothing :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Not sure how I missed this during testing.