Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Add Event for tripflare triggering #6663

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

nomisum
Copy link
Contributor

@nomisum nomisum commented Nov 6, 2018

When merged this pull request will:

  • add a CBA global event to tripflare triggering
  • _flare might be useful to delete / replace flare
  • _position is already available, so why not send it too (no need to getpos on the other side)

_flare might be useful to delete / replace flare
_position is already available, so why not send it too
@TheMagnetar
Copy link
Member

Can this be also documented?

also added missing wirecutter event
@nomisum
Copy link
Contributor Author

nomisum commented Nov 6, 2018

Added documentation, also added missing wirecutter event documentation

Renamed Logistics section to Cargo, as it contains cargo specific stuff only and "logistics" is now only wirecutter and uav batteries afaik

@@ -47,7 +47,7 @@ MenuType: 0 = Interaction, 1 = Self Interaction
|`ace_interactMenuOpened` | [_menuType] | Local | Listen | Interaction Menu Opened
|`ace_interactMenuClosed` | [_menuType] | Local | Listen | Interaction Menu Closed

### 2.4 Logistics (`ace_cargo`)
### 2.4 Cargo (`ace_cargo`)
Copy link
Member

@bux bux Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

careful, this will make some potential incoming links kaputt!
Could you please do a string search for ace wiki pages that link to that section (if there are any) and rewrite that link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 matches in 5251 files it seems 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that would make sense to link here would be https://ace3mod.com/wiki/framework/cargo-framework.html#21-listenable
But as you can see it has it's own table. Maybe we could just link here instead of having a copy of the table?
Would be bad UX tho.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same irritation. Would be great if the events site could aggregate all the event sections from the single framework pages.

Buuuut I dont think reworking the entire structure is in the scope of this PR ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could write a script to aggregate and link them all across. I like them on framework pages, each component gets one and is harder to miss something outdated.

Not in scope of this PR as you said.

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Nov 6, 2018
@jonpas jonpas added this to the 3.13.0 milestone Nov 6, 2018
@PabstMirror PabstMirror changed the title Add Event for tripflare triggering Explosives - Add Event for tripflare triggering Nov 9, 2018
@PabstMirror PabstMirror merged commit ada0775 into acemod:master Nov 9, 2018
@nomisum nomisum deleted the patch-2 branch November 9, 2018 18:32
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Add Event for tripflare triggering

_flare might be useful to delete / replace flare
_position is already available, so why not send it too

* added documentation

also added missing wirecutter event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants