-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosives - Add Event for tripflare triggering #6663
Conversation
_flare might be useful to delete / replace flare _position is already available, so why not send it too
Can this be also documented? |
also added missing wirecutter event
Added documentation, also added missing wirecutter event documentation Renamed Logistics section to Cargo, as it contains cargo specific stuff only and "logistics" is now only wirecutter and uav batteries afaik |
@@ -47,7 +47,7 @@ MenuType: 0 = Interaction, 1 = Self Interaction | |||
|`ace_interactMenuOpened` | [_menuType] | Local | Listen | Interaction Menu Opened | |||
|`ace_interactMenuClosed` | [_menuType] | Local | Listen | Interaction Menu Closed | |||
|
|||
### 2.4 Logistics (`ace_cargo`) | |||
### 2.4 Cargo (`ace_cargo`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
careful, this will make some potential incoming links kaputt!
Could you please do a string search for ace wiki pages that link to that section (if there are any) and rewrite that link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 matches in 5251 files it seems 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing that would make sense to link here would be https://ace3mod.com/wiki/framework/cargo-framework.html#21-listenable
But as you can see it has it's own table. Maybe we could just link here instead of having a copy of the table?
Would be bad UX tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same irritation. Would be great if the events site could aggregate all the event sections from the single framework pages.
Buuuut I dont think reworking the entire structure is in the scope of this PR ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could write a script to aggregate and link them all across. I like them on framework pages, each component gets one and is harder to miss something outdated.
Not in scope of this PR as you said.
* Add Event for tripflare triggering _flare might be useful to delete / replace flare _position is already available, so why not send it too * added documentation also added missing wirecutter event
When merged this pull request will: