Medical - Show tourniquets in Medical and Patient information #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that using rewrite pictures or your custom ones? (If I am not mistaken rewrite does it a bit differently anyways?) |
|
Correct, I use the rewrite picture for the 4 tourniquets. In the rewrite iirc it uses the same image for all 4 but with rotation and so on. In mine I just made 4 images all like the separate body part images. |
|
Why don't work on rewrite instead? |
I do not have any real knowledge about the rewrite so far, right now I am just reacting to some things that I think are missing and a temp solution would be neat until the big update hits. |
jonpas
requested changes
Nov 16, 2018
|
Updated pr with requested changes |
dedmen
reviewed
Nov 17, 2018
|
Anything else needs changing? |
thojkooi
added
kind/enhancement
|
Images are so weird. |
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Show tourniquets in Medical and Patient information * Ace styling * Move tourniquet update function to medical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Show applied tourniquets in the medical menu and Patient information view
Adds 4 new images for each tourniquet
Adds code to handle the opacity of all 4 new UI entries respectively for the medical menu and the Patient information view
I know the medical rewrite is in the works, but this might be months and maybe like a year away. That is why I thought adding this in the mean time has some benefits even if it will be removed in the future.