Dragging - Additional weight override parameter for setCarryable/setDraggable #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2019 22:08
…raggable - Additional optional parameter that ignores the `startCarry`/`startDrag` weight checks. - Minor `==` to `isEqualto` replacements
- remove \t
commy2
suggested changes
Jan 20, 2019
There was a problem hiding this comment.
Not a fan of scopeName/breakTo/Out.
Should be written it like this imo:
if (!GETVAR(_target,GVAR(ignoreWeightCarry),false) && {
private _weight = [_target] call FUNC(getWeight);
_weight > (GETMVAR(ACE_maxWeightCarry,1E11))
}) exitWith {
[localize LSTRING(UnableToDrag)] call EFUNC(common,displayTextStructured);
};
|
for Should I skip the variable and do |
|
Either is fine I think, but I prefer more locals (with descriptive names) instead of long lines that are hard to read. |
commy2
reviewed
Jan 20, 2019
Co-Authored-By: PiZZAD0X <509thparachuteinfantry@gmail.com>
commy2
reviewed
Jan 20, 2019
Co-Authored-By: PiZZAD0X <509thparachuteinfantry@gmail.com>
commy2
approved these changes
Jan 20, 2019
PabstMirror
changed the title
PabstMirror
approved these changes
Jan 20, 2019
dedmen
reviewed
Jan 22, 2019
| @@ -27,4 +27,4 @@ if ((_unit getHitPointDamage "HitLegs") >= 0.5) exitWith {false}; | |||
| // a static weapon has to be empty for dragging (ignore UAV AI) | |||
| if (((typeOf _target) isKindOf "StaticWeapon") && {{(getText (configFile >> "CfgVehicles" >> (typeOf _x) >> "simulation")) != "UAVPilot"} count crew _target > 0}) exitWith {false}; | |||
|
|
|||
| alive _target && {vehicle _target == _target} && {_target getVariable [QGVAR(canCarry), false]} && {animationState _target in ["", "unconscious"] || (_target getVariable ["ACE_isUnconscious", false]) || (_target isKindOf "CAManBase" && {(_target getHitPointDamage "HitLegs") > 0.4})} | |||
| alive _target && {vehicle _target isEqualto _target} && {_target getVariable [QGVAR(canCarry), false]} && {animationState _target in ["", "unconscious"] || (_target getVariable ["ACE_isUnconscious", false]) || (_target isKindOf "CAManBase" && {(_target getHitPointDamage "HitLegs") > 0.4})} | |||
3 tasks
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
…raggable (#6780) * Added weight override parameter to ace_dragging_fnc_setCarryable/setDraggable - Additional optional parameter that ignores the `startCarry`/`startDrag` weight checks. - Minor `==` to `isEqualto` replacements * `count crew _target isEqualto -1` to `count crew _target isEqualto 0` * Tab Replacement - remove \t * Reverted UAV check, Params formatting, Lazy Eval * Update addons/dragging/functions/fnc_startCarry.sqf Co-Authored-By: PiZZAD0X <509thparachuteinfantry@gmail.com> * Update fnc_startDrag.sqf * Remove beta suggestion extra line additions * Update addons/dragging/functions/fnc_startDrag.sqf Co-Authored-By: PiZZAD0X <509thparachuteinfantry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Add an additional optional parameter to the
ace_dragging_fnc_setCarryableandace_dragging_fnc_setDraggablefunctions that sets a object variable that can skip the weight check inace_dragging_fnc_startCarryandace_dragging_fnc_startCarryrespectively.Existing function parameter format is
[object, true, [0,1,1], 0] call ace_dragging_fnc_setCarryable;which is compatible with this PR.eg.
[object, true, [0,1,1], 0, true] call ace_dragging_fnc_setCarryable;would override the carry weight check on the object.
This would be useful if mission makers want the ability to carry/drag a specific heavy object without disabling/nullifying the weight checks globally, similar to how mission makers could use
setMassin the past.Addresses setMass 1, still can't lift #4141
Test mission with objects below and over weight limit, with and without function.
ACE_carryWeightExceptionTest.VR.zip