version check handle minor versions below 10 #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3.9.123456 Before: After: 3.10.123456 Before: After: 3.9 > 3.1 (bugged) |
thojkooi
approved these changes
Mar 16, 2019
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
version check handle minor versions below 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Note that a big rewrite of this function, that would for example handle
1.99 < 1.100etc. correctly is not desirable. The function has to be cross compatible between all versions due to its nature and therefore this transferred variable should stay a number and not become an array or string.