Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Feedback - Fix DISABLE_VANILLA_DAMAGE_EFFECTS #6966

Merged
merged 2 commits into from
Apr 27, 2019

Conversation

PabstMirror
Copy link
Contributor

DISABLE_VANILLA_DAMAGE_EFFECTS was only defined in medical_feedback
so it wasn't running, and I'm pretty sure this is where it belongs
it's also now under a hasInterface check

@PabstMirror PabstMirror added the ignore-changelog Release Notes: Excluded label Apr 27, 2019
@PabstMirror PabstMirror added this to the Medical Rewrite milestone Apr 27, 2019
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what the UAV pilot thing does here, but looks good to me.

@PabstMirror
Copy link
Contributor Author

ai would be handled inside the init:

        if (getText (_config >> "simulation") == "UAVPilot") exitWith {TRACE_1("ignore UAV AI",typeOf _unit);};

this just skips adding the initEH to AI classes

also pushed a small change to keep the old var name
_unit setVariable [QEGVAR(medical,lastDamageSource), _shooter];
to ensure compatiblity with acex_killtracker and possibly other missions that would use this var to determine killer

@PabstMirror PabstMirror merged commit 0d77096 into master Apr 27, 2019
@PabstMirror PabstMirror deleted the medVanillaFeedback branch April 27, 2019 19:04
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Medical Feedback - Fix DISABLE_VANILLA_DAMAGE_EFFECTS

* Keep compatibilty with old ace_medical_lastDamageSource var name
@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants