Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing playsound3d limits #7024

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Fixing playsound3d limits #7024

merged 1 commit into from
Nov 5, 2019

Conversation

Cyruz143
Copy link
Contributor

When merged this pull request will:

  • Adhere to the new 5x sound limit in MP with playsound3d

I've bumped the ranges on some of the sounds to counter the volume lowering. I've not tested it in-game, just used some guess work on the numbers.

@PabstMirror PabstMirror added this to the 3.13.0 milestone May 29, 2019
@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** status/needs-testing labels May 29, 2019
@severgun
Copy link
Contributor

Any chance to include fix for #6861 ?

@PabstMirror
Copy link
Contributor

Tested working
This pr puts the params into spec for the playSound3d command
some sounds are still a little quieter than they used to be before the command changed
(I remember the hot wirebreak being loud)
I guess the only way to fix would be to modify the sound file to increase loudness

@PabstMirror PabstMirror merged commit 5033a98 into acemod:master Nov 5, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants