Logistics enable/disable settings (no more compat 🎉) #7040
Conversation
| GVAR(hooks)[] = {{0, 0.4, -0.5}, {0, -0.4, -0.5}}; | ||
| GVAR(fuelCargo) = REFUEL_INFINITE_FUEL; | ||
| }; | ||
| class Land_FuelStation_01_pump_malevil_F: House_F { | ||
| transportFuel = 0; //50k |
There was a problem hiding this comment.
setFuelCargo won't work on map objects
e.g. the fuel station on stratis ([2713, 5796]) will fill a empty car
There was a problem hiding this comment.
I knew this command is somehow broken.
There was a problem hiding this comment.
Will check that. Hiding and replacing it with a simple object might be an option.
There was a problem hiding this comment.
setFuelCargowon't work on map objects
e.g. the fuel station on stratis ([2713, 5796]) will fill a empty car
It does work, you must just handle all 3 pumps at the station.
The real problem here is that fuel pumps are Static children and they don't trigger InitPost EH. This can be handled with nearestObjects or nearObjects call with each pump class at mission init. But how to handle pumps created during mission with createVehicle after mission init?
At least fuel pumps class CBA_Extended_EventHandlers removed in #4533 can be restored. But this must be done also for all 3rd party pumps so some compat can be needed.
There was a problem hiding this comment.
terrain objects can also stream in/out, and might not store their fuel state inbetween.
There was a problem hiding this comment.
I already tested this here #7613 (comment)
burp |
|
If something does I'd rather defer the refuel/rearm compats to another PR, they'll need lots more special handling from the looks of it. |
Why? We have a framework for item replacement already and it stays compatible with the vanilla attributes. This is a regression. |
|
I'd like to avoid item replacement because of custom toolkits. I'm aware item types can be replaced directly, but what about those custom toolkits' mass, item description, or whatever other custom properties? Or any other mod/mission checking for toolkit items by type, or for the item itself? |
|
Succeeded by other PRs. |
When merged this pull request will:
Status: