Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined variable in View Distance #7142

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Aug 14, 2019

When merged this pull request will:

Needs to be tested and made sure switching functions accordingly. I assumed here that when switching to "Off" nothing changes (unless it was in FoV mode) and is simply a way to allow setting object view distance via vanilla settings (simple disable of ACE system).

@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Aug 14, 2019
@jonpas jonpas added this to the 3.13.0 milestone Aug 14, 2019
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those var names tho

Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ace_viewdistance_fovbasedpfhminimalviewdistance
💅

Don't think this can cause any further problems, just fixes a nil access

@jonpas
Copy link
Member Author

jonpas commented Aug 15, 2019

I wrote this in 2016 alright!

@commy2 commy2 merged commit d1784ad into master Aug 21, 2019
@commy2 commy2 deleted the fix-viewdistance-undef-var branch August 21, 2019 21:04
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined Variable in viewDistance if not in FOV mode
4 participants