Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goggle overlay support for Contact update Blindfolds #7157

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

veteran29
Copy link
Member

When merged this pull request will:

  • Title

Texture by @BaerMitUmlaut

Images

image

@commy2
Copy link
Contributor

commy2 commented Aug 30, 2019

Should name the file _ca before converting with img2paa.

@veteran29
Copy link
Member Author

I have done that. Then renamed to Blindfold.paa. Conversion was done with TexView 2

@jonpas
Copy link
Member

jonpas commented Aug 30, 2019

Then renamed to Blindfold.paa.

Why though?

@veteran29
Copy link
Member Author

veteran29 commented Aug 30, 2019

Why though?

Because all other textures in the component are named like that.

@commy2
Copy link
Contributor

commy2 commented Aug 30, 2019

They shouldn't.

@veteran29
Copy link
Member Author

Should I fix all of them then?

@commy2
Copy link
Contributor

commy2 commented Aug 31, 2019

Make sure to convert them when named _ca, so

  • paa → png
  • rename _ca.png
  • png → paa

@jones140
Copy link

Overlay for new respirator gear as well?

Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me
just a reminder that goggles effects are now client settable, so you would need to enforce the setting if you need the effect for a mission

@jonpas
Copy link
Member

jonpas commented Oct 6, 2019

just a reminder that goggles effects are now client settable, so you would need to enforce the setting if you need the effect for a mission

This should have an override then.

@veteran29
Copy link
Member Author

Merge? Goggles can be forced via setting. Option to force googles per goggle class should be separate PR anyway imho.

@commy2
Copy link
Contributor

commy2 commented Nov 25, 2019

Agreed. Goggles component needs a rewrite anyway. Once I find my life again, I will do it.

@jonpas jonpas merged commit f336b6c into acemod:master Dec 7, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants