Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CBA Versioning System properly #7173

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Use CBA Versioning System properly #7173

merged 3 commits into from
Sep 10, 2019

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Sep 6, 2019 •
edited
Loading

When merged this pull request will:

  • Title

Merge after CBATeam/CBA_A3#1221 is released!

TODO:

  • Copy updated script_macros_common.hpp on CBA release
    • With cleaned-up quoting ##

@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** kind/task target/next-cba labels Sep 6, 2019
@jonpas jonpas added this to the Backlog milestone Sep 6, 2019
@jonpas jonpas modified the milestones: Backlog, 3.13.0 Sep 10, 2019
@jonpas
Copy link
Member Author

jonpas commented Sep 10, 2019

CBA released, this is done and ready for merge.

@mharis001
Copy link
Member

Should this bump REQUIRED_CBA_VERSION?

@jonpas
Copy link
Member Author

jonpas commented Sep 10, 2019

No need, if older CBA version is used with this it'll just show the short version (v3.12) instead of the full one (v3.12.6.43) in the map "CBA > Credits" section.

@jonpas jonpas merged commit 2d0c61a into master Sep 10, 2019
@jonpas jonpas deleted the versioncfg branch September 10, 2019 15:49
@mharis001 mharis001 mentioned this pull request Sep 11, 2019
Merged
@jonpas jonpas mentioned this pull request Dec 18, 2019
Merged
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp1 Dec 30, 2019
@PabstMirror PabstMirror mentioned this pull request Jan 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/task
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jonpas @mharis001 @PabstMirror