Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cook Off - Change Cook Off events to global and add to events docs #7416

Merged
merged 2 commits into from
Jan 11, 2020

Conversation

Dahlgren
Copy link
Member

@Dahlgren Dahlgren commented Jan 7, 2020

When merged this pull request will:

  • Broadcast ace_cookoff_cookOff, ace_cookoff_cookOffBox and ace_cookoff_engineFire globally, event wasn't sent locally before
  • Add both events to events documentation

@Dahlgren
Copy link
Member Author

Dahlgren commented Jan 7, 2020

I'll do some SP and MP testing tonight

@PabstMirror
Copy link
Contributor

fnc_handleDamage (where vehicle is local) calls fnc_cookOff
fnc_cookOff (where vehicle is local) calls the event on all other remote machines
event triggers fnc_cookOff to run on all other machines

So this isn't needed for functionality, but would allow the event to be used publicly
(shouldn't cause problems because it's gated with the isCookingOff setVar check)

@PabstMirror PabstMirror added this to the 3.13.1 milestone Jan 7, 2020
@PabstMirror PabstMirror added area/documentation kind/enhancement Release Notes: **IMPROVED:** labels Jan 7, 2020
@commy2
Copy link
Contributor

commy2 commented Jan 8, 2020

pls test, before this deadlocks the game

@Dahlgren
Copy link
Member Author

Dahlgren commented Jan 8, 2020

Did some SP testing yesterday which worked fine after fixing the other bug (#7419). I'll try to do the MP part today.

@PabstMirror
Copy link
Contributor

if (_vehicle getVariable [QGVAR(isEngineSmoking), false]) exitWith {};
_vehicle setVariable [QGVAR(isEngineSmoking), true];

this should prevent infinite recursion, but actual testing is always good

@Dahlgren
Copy link
Member Author

Dahlgren commented Jan 9, 2020

Seems to work good in MP as well

@commy2 commy2 merged commit 08a8384 into acemod:master Jan 11, 2020
@Dahlgren Dahlgren deleted the feature/cook-off-event branch November 10, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants