(Ready) Adds more laser functionality to aircraft #7509

LorenLuke · 2020-02-05T04:48:37Z

When merged this pull request will:

Create laser spot tracker functionality for pilot cam-equipped fixed wing aircraft
~~[ ] Enable the usage of a marker laser (https://youtu.be/hv2gBHVXZds?t=169) for indication by plane to point to a location. (MP Compatible)~~
Enable self laser tracking- When ground-tracking in the pilot camera, flicking the laser on/off slaves the ground-track to the lased point, enabling tracking of points on buildings or objects as you orbit, rather than the ground behind them (like here: https://youtu.be/IOZ18GNPI-c?t=75).
~~[x] Adds marker laser to gunner stations (including helicopters and fixed wing turreted aircraft, i.e. Blackfish, 3rd party add-on second seat operators, e.g. F/A-18B/D).~~
- Find alternate handling for weird non-primary turret LDs on vehicles, e.g. for Blackfish.
~~[ ] Adds marker laser option for handheld Laser designators (toggleable/keybind).~~

Known issues:

~~Currently available on Pilot camera fixed wing craft only. (Will fix)~~ Fixed.
~~Some amount of marker laser/laser seeker detachment from target pod orientation when targeting on water. (Cannot fix?)~~
~~Laser point tracking on certain buildings (e.g. Airstation Mike 26 Radome), where the geometry is transparent to the laser seeker does not generate a tracking point. (May attempt fix)~~
Sometimes, moving a ground-track point with an active laser doesn't track the laser point on a building. Stopgap Fix: switch laser off and on to track point on building.
~~Position of laser doesn't correspond to targeting pod location while at speed. (Cannot fix?)~~ Fixed! Thanks @BaerMitUmlaut!

Intended Behavior, which may be mistaken for bugs:

When tracking a laser point on a building, switching the laser off will still keep the same track point until the camera is moved.
Laser Spot Tracker does not follow a laser point after being set to 'ground track'. This is intentional so as to have a quick way to move the laser tracker without it being constantly pulled towards a particular laser spot.
~~Marker laser doesn't shine when turned on, except when designating. This is primarily for code reasons. If there exists worry about laser designating the wrong target, switch your laser code.~~

Marking this as 'Review Ready'.

addons/laser/XEH_postInit.sqf

BrettMayson · 2020-02-05T23:25:06Z

addons/laser/functions/fnc_keyLaserCodeChange.sqf

-if (((getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> "laser")) == 0) &&
-        {(getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> QGVAR(canSelect))) == 0}) exitWith {false};
+if (((getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> "laser")) == 0) && 
+    (!(_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false]) ) && 


Suggested change

(!(_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false]) ) &&

{!(_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false])} &&

BrettMayson · 2020-02-05T23:26:29Z

addons/laser/functions/fnc_keyLaserCodeChange.sqf

+private _string = "";
+if (_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false]) then {
+    private _LSTmessage = "";
+    if(_currentShooter getVariable [QGVAR(laserSpotTrackerOn), false]) then {_LSTmessage = localize LSTRING(LSTOn)} else {_LSTmessage = localize LSTRING(LSTOff)};


Split into multiple lines

this should be better than spliting it

Suggested change

if(_currentShooter getVariable [QGVAR(laserSpotTrackerOn), false]) then {_LSTmessage = localize LSTRING(LSTOn)} else {_LSTmessage = localize LSTRING(LSTOff)};

private _LSTmessage = localize ([LSTRING(LSTOff), LSTRING(LSTOn)] select (_currentShooter getVariable [QGVAR(laserSpotTrackerOn), false]));

addons/laser/functions/fnc_toggleLST.sqf

BrettMayson · 2020-02-05T23:31:41Z

addons/laser/functions/fnc_toggleLST.sqf

+    params ["_args", "_pfID"];
+    _args params ["_vehicle"];
+
+    if (!(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false])) exitWith {


Suggested change

if (!(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false])) exitWith {

if !(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false]) exitWith {

BrettMayson · 2020-02-05T23:32:14Z

addons/laser/stringtable.xml

@@ -63,5 +63,11 @@
            <Chinesesimp>雷射 - 循环切换雷射码 下</Chinesesimp>
            <Chinese>雷射 - 循環切換雷射碼 下</Chinese>
        </Key>
+        <Key ID="STR_ACE_Laser_LSTOn">
+            <English>Laser Spot Tracker- On</English>


- Space before dash

BrettMayson · 2020-02-05T23:32:18Z

addons/laser/stringtable.xml

+            <English>Laser Spot Tracker- On</English>
+        </Key>
+        <Key ID="STR_ACE_Laser_LSTOff">
+            <English>Laser Spot Tracker- Off</English>


- Space before dash

dedmen · 2020-02-10T09:47:53Z

addons/laser/XEH_postInit.sqf

+["ace_laserOn", {
+    params ["_uuid", "_args"];
+    private _vehicle = _args select 0;
+    if(hasPilotCamera _vehicle) then {


Suggested change

if(hasPilotCamera _vehicle) then {

if (hasPilotCamera _vehicle) then {

dedmen · 2020-02-10T09:48:12Z

addons/laser/XEH_postInit.sqf

+
+["Plane", "init", {
+    params ["_vehicle"];
+    _hasPilotCamera = hasPilotCamera _vehicle;


Suggested change

_hasPilotCamera = hasPilotCamera _vehicle;

private _hasPilotCamera = hasPilotCamera _vehicle;

dedmen · 2020-02-10T09:48:26Z

addons/laser/XEH_postInit.sqf

+
+["Air", "init", {
+    params ["_vehicle"];
+    _hasPilotCamera = hasPilotCamera _vehicle;


Suggested change

_hasPilotCamera = hasPilotCamera _vehicle;

private _hasPilotCamera = hasPilotCamera _vehicle;

addons/laser/functions/fnc_drawLaserLine.sqf

dedmen · 2020-02-10T09:50:15Z

addons/laser/functions/fnc_keyLaserCodeChange.sqf

@@ -40,8 +40,9 @@ if (isNull (ACE_controlledUAV param [0, objNull])) then {
 };

 TRACE_2("",_currentShooter,_currentWeapon);
-if (((getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> "laser")) == 0) &&
-        {(getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> QGVAR(canSelect))) == 0}) exitWith {false};
+if (((getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> "laser")) == 0) && 


Suggested change

if (((getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> "laser")) == 0) &&

private _currentWeaponCfg = configFile >> "CfgWeapons" >> _currentWeapon;

if ((getNumber (_currentWeaponCfg >> "laser") == 0) &&

Save some repeated lookups. Same in the lower conditions.
Not sure if worth, but IMO also better readability through shother lines.

dedmen · 2020-02-10T09:55:12Z

addons/laser/functions/fnc_toggleLST.sqf

+
+    if((getPilotCameraTarget _vehicle) select 0) then {
+        private _distance = ((getPilotCameraTarget _vehicle) select 1) distance _foundTargetPos;
+        if(_distance > 0.5) then {


Suggested change

if(_distance > 0.5) then {

if (_distance > 0.5) then {

dedmen · 2020-02-10T09:55:24Z

addons/laser/functions/fnc_toggleMarker.sqf

+params ["_vehicle"];
+
+_hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];
+if (! _hasMarker) exitWith {};


Suggested change

if (! _hasMarker) exitWith {};

if (!_hasMarker) exitWith {};

dedmen · 2020-02-10T09:55:30Z

addons/laser/functions/fnc_toggleMarker.sqf

+
+params ["_vehicle"];
+
+_hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];


Suggested change

_hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];

private _hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];

dedmen · 2020-02-10T09:56:06Z

addons/laser/functions/fnc_toggleMarker.sqf

+private _enabled = _vehicle getVariable [QGVAR(laserMarkerOn), false];
+_vehicle setVariable [QGVAR(laserMarkerOn), !_enabled];
+
+private _markerMessage = if(_vehicle getVariable [QGVAR(laserMarkerOn), false]) then {localize LSTRING(LaserMarkOn)} else {localize LSTRING(LaserMarkOff)};


Suggested change

private _markerMessage = if(_vehicle getVariable [QGVAR(laserMarkerOn), false]) then {localize LSTRING(LaserMarkOn)} else {localize LSTRING(LaserMarkOff)};

private _markerMessage = localize ([LSTRING(LaserMarkOff), LSTRING(LaserMarkOn)] select (_vehicle getVariable [QGVAR(laserMarkerOn), false]));

dedmen · 2020-02-10T09:56:45Z

addons/laser/functions/fnc_toggleMarker.sqf

+    } forEach _lightpoints;
+    _vehicle setVariable [QGVAR(markerlightpoints), []];
+
+    if ( !(_vehicle getVariable [QGVAR(laserMarkerOn), false]) || !(alive _vehicle) ) exitWith {


Suggested change

if ( !(_vehicle getVariable [QGVAR(laserMarkerOn), false]) || !(alive _vehicle) ) exitWith {

if (!(_vehicle getVariable [QGVAR(laserMarkerOn), false]) || !(alive _vehicle)) exitWith {

This can be simplified: !a || !b == !(a && b)

JonBons · 2020-02-10T18:10:40Z

addons/laser/functions/fnc_toggleMarker.sqf

+    private _num = 20;
+    for "_i" from 1 to _num do {
+        private _toPos = (_laserSource vectorAdd (_vector vectorMultiply _distance)) vectorAdd [sin(_i*(360/_num))*0.075,cos(_i*(360/_num))*0.075,0];
+        [ASLToAGL (_laserSource), ASLToAGL (_toPos), [0.8,1,0.8,1]] remoteExec [QFUNC(drawLaserLine), 0, false];


This seems like a bad idea running a global remoteExec 20 times every frame, can you not just store/transfer the needed vars over and run the loop to call drawLaserLine locally or am I completely off base or incorrect?

The way to reduce the calls would be to just to stuff them all into an array of arrays and have the draw command parse the entire array out within the draw script itself.
It'll reduce the network calls, but I feel it'd make the draw function a bit clunkier and, ultimately, all the draw events would have to happen anyway. I can cut the number down to somewhere between 12-15, but considering it's literally only being use to call a lightweight script I'm unsure how much impact it would have.

Though I honestly don't know, so if there's a second or third opinion on this, I'm happy to hear it.

This seems like a bad idea running a global remoteExec 20 times every frame

The messages are only transmitted once per frame.. so doing 20 per frame doesn't make much sense

The idea was to try and keep the draw script as lightweight as possible before, now instead of calling the draw script times, it only calls it once, but with an array of elements to iterate through.
Which method is better? I don't know.

TheCandianVendingMachine · 2020-02-12T05:00:58Z

addons/laser/CfgVehicles.hpp

+            class ACE_Equipment {
+                class ACE_ToggleMarkerLaser {
+                    displayName = CSTRING(laserMarkToggle);
+                    condition = QUOTE('Laserdesignator' in weapons ACE_player);


Probably want something like getNumber (configFile >> "CfgWeapons" >> (typeOf binocular ACE_PLAYER) >> QGVAR(whateverconfigname)) == 1 so that mods can add functionality without a headache

PabstMirror · 2020-02-12T05:24:42Z

addons/laser/functions/fnc_toggleMarkerHand.sqf

+        private _toPos = (_laserSource vectorAdd (_vector vectorMultiply _distance)) vectorAdd [sin(_i*(360/_num))*0.005,cos(_i*(360/_num))*0.005,0];
+        _list pushback [ASLToAGL (_laserSource), ASLToAGL (_toPos), [0.8,1,0.8,1]];
+    };
+    [_list] remoteExec [QFUNC(drawLaserLine), 0, false];


We can't assume the fps on clients will be the same

How would FPS being different among clients have bearing on, or be consequence of, this code snippet?

fnc_drawLaserLine does drawLine3D
this PFEH calls that on all machines
so if client A is running the PFEH with 20 fps, and client B has 50, B will have a flickering line
TBH I have no idea how this will work in real MP (with latency), there is little guarantee when the packets will arrive

RE also runs scheduled btw. REC is no quick fix either. RE is banned. The idea of remote execution on every frame is insanity.

commy2 · 2020-02-12T19:46:08Z

addons/laser/XEH_postInit.sqf

+        if (_ctrl) then {_key = _key + 486539264};
+        if (_shift) then {_key = _key + 704643072};
+        if (_alt) then {_key = _key + 939524096};
+        private _lightKeys = actionKeys "headlights";


This does not work. Floats too big. actionKeys command is unusable. This method cannot be saved. Rethink it from the beginning.

commy2 · 2020-02-12T19:46:26Z

addons/laser/XEH_postInit.sqf

+
+["CAManBase", "init", {
+    params ["_unit"];
+    findDisplay 46 displayAddEventHandler ["KeyDown", {


Not savegame compatible.

commy2 · 2020-02-12T19:46:52Z

addons/laser/functions/fnc_toggleMarker.sqf

+        private _toPos = (_laserSource vectorAdd (_vector vectorMultiply _distance)) vectorAdd [sin(_i*(360/_num))*0.05,cos(_i*(360/_num))*0.005,0];
+        _list pushback [ASLToAGL (_laserSource), ASLToAGL (_toPos), [0.8,1,0.8,1]];
+    };
+    [_list] remoteExec [QFUNC(drawLaserLine), 0, false];


RE is banned.

commy2 · 2020-02-12T19:50:25Z

addons/laser/functions/fnc_toggleMarker.sqf

+if (_weapons find "Laserdesignator_mounted" > -1) then {
+    _weapon = "Laserdesignator_mounted";
+} else {
+    _weapon = "Laserdesignator_pilotCamera";


Hard coded classnames.

commy2 · 2020-02-12T19:52:47Z

I don't like any of this. It is not ready to be reviewed. As it stands now, it needs to be completely rewritten.

commy2

I thought I was on armadev for a minute.

LorenLuke · 2020-02-12T23:08:06Z

I thought I was on armadev for a minute.

@commy2
Why would that be?

commy2 · 2020-02-12T23:34:12Z

It's poorly written.

dedmen · 2020-06-03T12:40:07Z

addons/laser/functions/fnc_keyLaserCodeChange.sqf

@@ -19,7 +19,7 @@ params [["_codeChange", 0, [0]]];

 TRACE_1("params",_codeChange);

-if ((!alive ACE_player) || {!([ACE_player, vehicle ACE_player, []] call EFUNC(common,canInteractWith))}) exitWith {false};
+if (( !alive ACE_player) || {!([ACE_player, vehicle ACE_player, []] call EFUNC(common,canInteractWith))}) exitWith {false};


stray space added?

dedmen · 2020-06-03T12:41:17Z

addons/laser/functions/fnc_keyLaserCodeChange.sqf

+private _string = "";
+if (_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false]) then {
+    private _LSTmessage = localize ([LSTRING(LSTOff), LSTRING(LSTOn)] select (_currentShooter getVariable [QGVAR(laserSpotTrackerOn), false]));
+    _string = format ["%1<br/>", _LSTmessage];


I would say format is probably more expensive than +

Suggested change

_string = format ["%1<br/>", _LSTmessage];

_string = _LSTmessage + "<br/>";

dedmen · 2020-06-03T12:41:37Z

addons/laser/functions/fnc_laserPointTrack.sqf

+GVAR(TrackerpfID) = [{
+    params ["_args", "_pfID"];
+    _args params ["_vehicle"];
+    if ( !(hasPilotCamera _vehicle)) exitWith {


Suggested change

if ( !(hasPilotCamera _vehicle)) exitWith {

if (!(hasPilotCamera _vehicle)) exitWith {

dedmen · 2020-06-03T12:41:44Z

addons/laser/functions/fnc_laserPointTrack.sqf

+    if ( !(hasPilotCamera _vehicle)) exitWith {
+        [_pfID] call CBA_fnc_removePerFrameHandler;
+    };
+    if (isNull(laserTarget _vehicle)) exitWith {


Suggested change

if (isNull(laserTarget _vehicle)) exitWith {

if (isNull (laserTarget _vehicle)) exitWith {

dedmen · 2020-06-03T12:41:50Z

addons/laser/functions/fnc_laserPointTrack.sqf

+    if (isNull(laserTarget _vehicle)) exitWith {
+        [_pfID] call CBA_fnc_removePerFrameHandler;
+    };
+    if ( !((getPilotCameraTarget _vehicle) select 0)) exitWith {


Suggested change

if ( !((getPilotCameraTarget _vehicle) select 0)) exitWith {

if (!((getPilotCameraTarget _vehicle) select 0)) exitWith {

dedmen · 2020-06-03T12:43:38Z

addons/laser/functions/fnc_seekerFindLaserSpot.sqf

@@ -79,7 +84,9 @@ private _finalOwner = objNull;
                private _testPointVector = _posASL vectorFromTo _testPoint;
                private _testDotProduct = _dir vectorDotProduct _testPointVector;
                if ((_testDotProduct > _seekerCos) && {(_testPoint vectorDistanceSqr _posASL) < _seekerMaxDistSq}) then {
-                    _spots pushBack [_testPoint, _owner];
+                    if(_owner != _ignoreBy) then {


Suggested change

if(_owner != _ignoreBy) then {

if (_owner != _ignoreBy) then {

dedmen · 2020-06-03T12:44:22Z

addons/laser/functions/fnc_toggleLST.sqf

+    params ["_args", "_pfID"];
+    _args params ["_vehicle"];
+
+    if ( !(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false]) || ( !alive _vehicle)) exitWith {


Suggested change

if ( !(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false]) || ( !alive _vehicle)) exitWith {

if (!(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false]) || (!alive _vehicle)) exitWith {

dedmen · 2020-06-03T12:45:04Z

addons/laser/functions/fnc_toggleLST.sqf

+    if ((getPilotCameraTarget _vehicle) select 0) then  {
+        _angle = 0.75;
+    };
+    private _pilotCameraLookPos = [sin(-deg(_pilotCameraRotation select 0)) * cos(-deg(_pilotCameraRotation select 1)), cos(-deg(_pilotCameraRotation select 0)) * cos(-deg(_pilotCameraRotation select 1)), sin(-deg(_pilotCameraRotation select 1))];


Suggested change

private _pilotCameraLookPos = [sin(-deg(_pilotCameraRotation select 0)) * cos(-deg(_pilotCameraRotation select 1)), cos(-deg(_pilotCameraRotation select 0)) * cos(-deg(_pilotCameraRotation select 1)), sin(-deg(_pilotCameraRotation select 1))];

private _pilotCameraLookPos = [

sin(-deg(_pilotCameraRotation select 0)) * cos(-deg(_pilotCameraRotation select 1)),

cos(-deg(_pilotCameraRotation select 0)) * cos(-deg(_pilotCameraRotation select 1)),

sin(-deg(_pilotCameraRotation select 1))

];

dedmen · 2020-06-03T12:45:36Z

addons/laser/initKeybinds.sqf

@@ -13,4 +13,4 @@
    [-1] call FUNC(keyLaserCodeChange);
 },
 {false},
-[18, [false, true, true]], false, 0] call CBA_fnc_addKeybind; // (ALT+CTRL+E)
+[18, [false, true, true]], false, 0] call CBA_fnc_addKeybind; // (ALT+CTRL+E)


missing newline at EOF

dedmen · 2020-06-03T12:46:08Z

addons/laser/stringtable.xml

@@ -63,5 +63,11 @@
            <Chinesesimp>雷射 - 循环切换雷射码 下</Chinesesimp>
            <Chinese>雷射 - 循環切換雷射碼 下</Chinese>
        </Key>
+        <Key ID="STR_ACE_Laser_LSTOn">
+            <English>Laser Spot Tracker: On</English>


I'm sure there is already a vanilla translation for On/Off that could be reused here, and get rid of the mostly duplicate entries here.

Where would I find it?

either unpack and search the vanilla stringtables dta/languagecore.pbo or
https://synixebrett.github.io/stringtables/
STR_ACTION_LASER_OFF
is a allcaps OFF
STR_3DEN_Attributes_Radar_RadarOff_text
is a normal Off

Meh... Can't find a "On" though

ACE3/addons/map/stringtable.xml

Line 388 in 7cc168e

<Key ID="STR_ACE_Map_Action_NVGOn">

Here are On and Off, but I see the german translation for example wouldn't fit here as it doesn't mean "enabled/on" but more like "one" the number.

ACE3/addons/viewdistance/stringtable.xml

Line 255 in d8f18c6

<Key ID="STR_ACE_ViewDistance_object_off">

Same...

ACE3/addons/microdagr/stringtable.xml

Line 118 in 35e4c2a

<Key ID="STR_ACE_MicroDAGR_settingOff">

same... did we just copy the same On/Off translations into multiple components? 🤔

dedmen · 2020-06-03T12:48:16Z

The title says ready, but there are still things that I already commented in my review 4 months ago, that are still wrong in multiple places (whitespace, codestyle)

LorenLuke · 2020-06-03T23:11:27Z

All the comments not having been made under the 48 hours previous to this one regarding code were each under comments marked 'outdated' or that had been removed, i.e. changes had been implemented on those files such that the code in question being questioned did not exist or (I had believed that) it had been rectified.
Most objections from other parties concerned the marker laser or its MP implementation, which is no longer present in this PR. Prior to further reply, all changes requested in the past 48 hours of this comment, not receiving a request for clarification will be changed to what is suggested.

Add laser spot tracker to fixed wing aircraft

da7614a

BrettMayson requested changes Feb 5, 2020

View reviewed changes

PabstMirror added the kind/feature Release Notes: **ADDED:** label Feb 7, 2020

PabstMirror added this to the Ongoing milestone Feb 7, 2020

Add Marker Laser and auto self-tracking

0a62877

LorenLuke changed the title ~~Adds laser spot tracker to fixed wing aircraft~~ Adds added laser functionality to fixed wing aircraft Feb 8, 2020

dedmen suggested changes Feb 10, 2020

View reviewed changes

JonBons reviewed Feb 10, 2020

View reviewed changes

LorenLuke added 2 commits February 10, 2020 17:15

Progress commit

f3aefd6

Release candidate 1

131e868

LorenLuke changed the title ~~Adds added laser functionality to fixed wing aircraft~~ (Ready) Adds more laser functionality to fixed wing aircraft Feb 12, 2020

LorenLuke changed the title ~~(Ready) Adds more laser functionality to fixed wing aircraft~~ (Ready) Adds more laser functionality to aircraft Feb 12, 2020

TheCandianVendingMachine reviewed Feb 12, 2020

View reviewed changes

PabstMirror reviewed Feb 12, 2020

View reviewed changes

commy2 reviewed Feb 12, 2020

View reviewed changes

commy2 suggested changes Feb 12, 2020

View reviewed changes

LorenLuke changed the title ~~(Ready) Adds more laser functionality to aircraft~~ (Not Ready) Adds more laser functionality to aircraft Feb 15, 2020

LorenLuke force-pushed the LST branch from ffb4de4 to c4600b2 Compare February 16, 2020 01:22

MP reWork (step 1)

8aebb02

LorenLuke force-pushed the LST branch from c4600b2 to 8aebb02 Compare February 16, 2020 01:23

Removes marker laser.

544f961

LorenLuke changed the title ~~(Not Ready) Adds more laser functionality to aircraft~~ (Ready) Adds more laser functionality to aircraft Jun 2, 2020

dedmen reviewed Jun 3, 2020

View reviewed changes

LorenLuke added 2 commits June 3, 2020 17:08

Addresses review (3 JUN 2020)

c5e7576

Adds newline to end of initKeybinds.sqf

8eb8423

BaerMitUmlaut mentioned this pull request Jun 14, 2020

Add IR marking laser for aircraft #7761

Open

5 tasks

LorenLuke requested a review from commy2 June 18, 2020 21:46

LorenLuke closed this Sep 24, 2021

LorenLuke mentioned this pull request Sep 24, 2021

Laser - Adds Aircraft Point Locking; Laser Spot Tracker #8453

Merged

LinkIsGrim removed this from the Ongoing milestone Jul 14, 2023

	(!(_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false]) ) &&
	{!(_currentShooter getVariable [QGVAR(hasLaserSpotTracker), false])} &&

	if(_currentShooter getVariable [QGVAR(laserSpotTrackerOn), false]) then {_LSTmessage = localize LSTRING(LSTOn)} else {_LSTmessage = localize LSTRING(LSTOff)};
	private _LSTmessage = localize ([LSTRING(LSTOff), LSTRING(LSTOn)] select (_currentShooter getVariable [QGVAR(laserSpotTrackerOn), false]));

	if (!(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false])) exitWith {
	if !(_vehicle getVariable [QGVAR(laserSpotTrackerOn), false]) exitWith {

	if(hasPilotCamera _vehicle) then {
	if (hasPilotCamera _vehicle) then {

	_hasPilotCamera = hasPilotCamera _vehicle;
	private _hasPilotCamera = hasPilotCamera _vehicle;

	if (((getNumber (configFile >> "CfgWeapons" >> _currentWeapon >> "laser")) == 0) &&
	private _currentWeaponCfg = configFile >> "CfgWeapons" >> _currentWeapon;
	if ((getNumber (_currentWeaponCfg >> "laser") == 0) &&


		params ["_vehicle"];

		_hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];

	_hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];
	private _hasMarker = _vehicle getVariable [QGVAR(hasMarkerLaser), false];

	private _markerMessage = if(_vehicle getVariable [QGVAR(laserMarkerOn), false]) then {localize LSTRING(LaserMarkOn)} else {localize LSTRING(LaserMarkOff)};
	private _markerMessage = localize ([LSTRING(LaserMarkOff), LSTRING(LaserMarkOn)] select (_vehicle getVariable [QGVAR(laserMarkerOn), false]));

	if ( !(_vehicle getVariable [QGVAR(laserMarkerOn), false]) \|\| !(alive _vehicle) ) exitWith {
	if (!(_vehicle getVariable [QGVAR(laserMarkerOn), false]) \|\| !(alive _vehicle)) exitWith {

	_string = format ["%1<br/>", _LSTmessage];
	_string = _LSTmessage + "<br/>";

	if ( !(hasPilotCamera _vehicle)) exitWith {
	if (!(hasPilotCamera _vehicle)) exitWith {

	if (isNull(laserTarget _vehicle)) exitWith {
	if (isNull (laserTarget _vehicle)) exitWith {

	if ( !((getPilotCameraTarget _vehicle) select 0)) exitWith {
	if (!((getPilotCameraTarget _vehicle) select 0)) exitWith {

	if(_owner != _ignoreBy) then {
	if (_owner != _ignoreBy) then {

(Ready) Adds more laser functionality to aircraft #7509

(Ready) Adds more laser functionality to aircraft #7509

Conversation

LorenLuke commented Feb 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jokoho48 Feb 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JonBons Feb 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LorenLuke Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

commy2 commented Feb 12, 2020

commy2 left a comment

Choose a reason for hiding this comment

LorenLuke commented Feb 12, 2020 • edited Loading

commy2 commented Feb 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedmen commented Jun 3, 2020

LorenLuke commented Jun 3, 2020

LorenLuke commented Feb 5, 2020 •

edited

Loading

jokoho48 Feb 6, 2020 •

edited

Loading

JonBons Feb 10, 2020 •

edited

Loading

LorenLuke Feb 12, 2020 •

edited

Loading

LorenLuke commented Feb 12, 2020 •

edited

Loading