Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map - Allow enabling BFT setting after mission start #7519

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Map - Allow enabling BFT setting after mission start #7519

merged 4 commits into from
Feb 12, 2020

Conversation

shukari
Copy link
Contributor

@shukari shukari commented Feb 10, 2020

When merged this pull request will:

  • change to CBA_fnc_addSetting not the internal fnc CBA_settings_fnc_init
  • some vars can edited in the mission
  • if BFT was disabled at mission start an den enabled it now works...

@shukari shukari changed the title Update initSettings.sqf BFT enable in mission Feb 10, 2020
@shukari shukari mentioned this pull request Feb 10, 2020
Closed
@commy2
Copy link
Contributor

commy2 commented Feb 10, 2020

Can you also disable it on the fly?

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Feb 10, 2020
@commy2 commy2 added this to the 3.13.1 milestone Feb 10, 2020
@shukari
Copy link
Contributor Author

shukari commented Feb 10, 2020 •
edited
Loading

@commy2 disable was always possible while the mission was running because:

ACE3/addons/map/functions/fnc_blueForceTrackingUpdate.sqf

Line 27 in fabe625

if (GVAR(BFT_Enabled) and {(!isNil "ACE_player") and {alive ACE_player}}) then {

@commy2
Copy link
Contributor

commy2 commented Feb 11, 2020 •
edited
Loading

This is now superfluous and should be deleted.

@shukari @PabstMirror
Update addons/map/initSettings.sqf
3353c3a 
Co-Authored-By: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror changed the title BFT enable in mission Map - Allow enabling BFT setting after mission start Feb 12, 2020
@PabstMirror PabstMirror merged commit 7c296c9 into acemod:master Feb 12, 2020
@shukari shukari deleted the patch-1 branch February 14, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettMayson BrettMayson BrettMayson left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@shukari @commy2 @BrettMayson @PabstMirror