Various - Conform isNil checks across the codebase #7523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
reviewed
Feb 12, 2020
commy2
reviewed
Feb 12, 2020
commy2
reviewed
Feb 12, 2020
commy2
previously requested changes
Feb 12, 2020
|
I see what you mean 🤦♂ . Will sort them out .... |
|
Think i caught most of the quotation wrong doings .... |
commy2
added
kind/cleanup
|
lgtm |
mharis001
reviewed
Feb 12, 2020
Co-Authored-By: mharis001 <34453221+mharis001@users.noreply.github.com>
Whigital
commented
Feb 13, 2020
PabstMirror
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
isNilchecks from!(isNil ....->(!isNil ....where applicable.isNilarg from....isNil _arg)->....isNil "_arg")where applicable.