Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastroping - Fix deployAI not unwinding ropes #7536

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fastroping - Fix deployAI not unwinding ropes #7536

merged 2 commits into from
Feb 20, 2020

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • After introduction of different rope lengths, deployRopes does not unwind ropes when called from deployAI because a rope class is not provided
  • This PR fixes that by using the old rope length of 34.5 when the config entry GVAR(ropeLength) is not a positive number

@mharis001 mharis001 added the kind/bug-fix Release Notes: **FIXED:** label Feb 20, 2020
@mharis001 mharis001 added this to the 3.13.1 milestone Feb 20, 2020
@mharis001 @PabstMirror
Add check for empty _ropeClass
e2725e5 
Co-Authored-By: PabstMirror <pabstmirror@gmail.com>
@commy2 commy2 merged commit 9e2a2f2 into master Feb 20, 2020
@jonpas jonpas deleted the fix-fastrope-deployAI branch February 20, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mharis001 @jonpas @PabstMirror @commy2