Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map - Detect switchable flashlight attachments for map #7578

Merged
merged 6 commits into from
Apr 7, 2020
Merged

Map - Detect switchable flashlight attachments for map #7578

merged 6 commits into from
Apr 7, 2020

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Mar 7, 2020 •
edited
Loading

When merged this pull request will:

  • title

Fixes #7130

Needs CBATeam/CBA_A3#1294

@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:** labels Mar 7, 2020
@PabstMirror PabstMirror modified the milestones: 3.13.2, Ongoing Mar 7, 2020
@PabstMirror
Copy link
Contributor

PabstMirror commented Mar 7, 2020 •
edited
Loading

  • - Update required CBA version (when it releases)

@jonpas
Copy link
Member

jonpas commented Mar 7, 2020

Backlog: Tasks that have a specific end point, but no due date.
Ongoing: Tasks that do not have a specific due date and are ongoing as circumstances change.

@jonpas jonpas modified the milestones: Ongoing, Backlog Mar 7, 2020
@jonpas jonpas removed the kind/bug-fix Release Notes: **FIXED:** label Mar 7, 2020
@veteran29
Improve isFlashlight function
ff65e5d 
This is embarrassing.
mharis001
mharis001 reviewed Mar 7, 2020
View reviewed changes
addons/map/functions/fnc_isFlashlight.sqf Outdated Show resolved Hide resolved
addons/map/functions/fnc_isFlashlight.sqf Outdated Show resolved Hide resolved
addons/map/functions/fnc_isFlashlight.sqf Outdated Show resolved Hide resolved
addons/map/functions/fnc_isFlashlight.sqf Outdated Show resolved Hide resolved
@veteran29 @mharis001
Apply suggestions from code review
eb6c97f 
Co-Authored-By: mharis001 <34453221+mharis001@users.noreply.github.com>
@PabstMirror PabstMirror modified the milestones: Backlog, 3.13.2 Apr 7, 2020
@PabstMirror PabstMirror changed the title Detect switchable flashlight attachments for map flashlight Map - Detect switchable flashlight attachments for map flashlight Apr 7, 2020
PabstMirror
PabstMirror approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@jonpas jonpas changed the title Map - Detect switchable flashlight attachments for map flashlight Map - Detect switchable flashlight attachments for map Apr 7, 2020
@jonpas jonpas merged commit 64c30a9 into acemod:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 left review comments

@commy2 commy2 commy2 left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.2
Development

Successfully merging this pull request may close these issues.

Map light doesn't detect laser/light attachments
5 participants
@veteran29 @PabstMirror @jonpas @commy2 @mharis001