Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - fix player's name showing as "Unknown" #7662

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Common - fix player's name showing as "Unknown" #7662

merged 1 commit into from
Apr 24, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Apr 24, 2020

When merged this pull request will:

  • Should fix "Unknown" being reported by getName in certain situations.

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Apr 24, 2020
@commy2 commy2 added this to the 3.13.3 milestone Apr 24, 2020
@PabstMirror
Copy link
Contributor

ACE3/addons/common/CfgEventHandlers.hpp

Line 48 in a8856e0

respawn = QUOTE(_this call FUNC(setName));

anyone know why we add it to All instead of CaManBase?

@commy2
Copy link
Contributor Author

commy2 commented Apr 24, 2020

There is no reason, but also no harm, as respawning vehicles don't raise the event.

@PabstMirror PabstMirror changed the title fix Unknown name Common - fix player's name showing as "Unknown" Apr 24, 2020
@commy2 commy2 merged commit 1d407b3 into master Apr 24, 2020
@commy2 commy2 deleted the fix-unknown branch April 24, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @PabstMirror