Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New group side in Leave Group interaction is same as original group side #7667

Merged
merged 1 commit into from
Apr 27, 2020
Merged

New group side in Leave Group interaction is same as original group side #7667

merged 1 commit into from
Apr 27, 2020

Conversation

billw2012
Copy link
Contributor

When merged this pull request will:

  • Change Leave Group interaction so the new group is the same side as the old group, not the same side as the player themselves. This is the safer behavior, as player side doesn't necessarily match their group side.

@billw2012
New group side in Leave Group interaction is same as original group side
2374cea 
Previously it would be `side player`, now it is `side group player`, which is more consistent (as unit and group sides are not necessarily the same).
@mharis001 mharis001 added the kind/bug-fix Release Notes: **FIXED:** label Apr 26, 2020
@mharis001 mharis001 added this to the 3.13.3 milestone Apr 26, 2020
@commy2 commy2 merged commit 8f1dc1d into acemod:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@jokoho48 jokoho48 jokoho48 approved these changes

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.
4 participants
@billw2012 @commy2 @jokoho48 @mharis001