switchUnits - Fix switching units not working (#6188) #7676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Clicking on a switchable unit currently does nothing (see #6188).
It looks like
BIS_fnc_addStackedEventHandler
was changed at some point so that the arguments array is appended toonMapSingleClick
's passed params, resulting in switchUnits failing here:https://github.com/acemod/ACE3/blob/master/addons/switchunits/functions/fnc_addMapFunction.sqf#L24
Quick fix would have been:
This replaces
BIS_fnc_addStackedEventHandler
with MapSingleClick mission eventhandler instead and introducesGVAR(switchableSides)
, because you can't pass arguments throughaddMissionEventHandler
.