-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHS Compat ADD Missing (undefined) Weapons #7702
RHS Compat ADD Missing (undefined) Weapons #7702
Conversation
…HS-Compat-CFG-Weapon-fixes"" This reverts commit 65709b7.
Resolved the Conflict, adjusted how the M14s were defined (0.51 RHS USAF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thats not how that works, the scopes function returns the height from config, and it also doesn't return heightAboveBore, it returns RailHeightAboveBore+ScopeHeightAboveRail. The config entry is there because the height cannot be determined using scripts and needs to be manually entered, so you cannot just run some script and enter the value it gives you. Please just leave the values empty if you don't actually have them. |
Reverted Railabovebore to the Values that existed before and removed the ones i added. |
As Written in Issue #7560 there were Weapons missing in the Compats.
I also took the Time to look into the Comming RHS version (0.51).
Added:
RHS USAF:
I used "call ace_scopes_fnc_getBoreHeight" to get the Railabove bore values but i am not 100% sure they are correct.Scar H CQC
ACE_barrelTwist = 304.8; // 1:12"
ACE_barrelLength = 330.0;
Scar H STD
ACE_barrelTwist = 304.8; // 1:12"
ACE_barrelLength = 406.0;
Scar H LB
ACE_barrelTwist = 304.8; // 1:12"
ACE_barrelLength = 508.0;
M14 Base ----> New Parent for all Mk14s
ACE_barrelTwist = 304.8;
ACE_barrelLength = 558.8;
Soccom 16
ACE_barrelTwist = 304.8;
ACE_barrelLength = 413; //16.25 in (413 mm)
Redefined
M240 and M249, M249 PIP and M249 were not completly accepting Values, M240B was defined, M240G wasnt.
RHS GREF:
Added
VHSD2
ACE_barrelTwist= 177.8;
ACE_barrelLength=500.0;
VHSK2
ACE_barrelTwist= 177.8;
ACE_barrelLength=410.0;
VHSD2_CT15x
ACE_barrelTwist= 177.8;
ACE_barrelLength=500.0;
VHSD2_BG (GL Variant)
ACE_barrelTwist= 177.8;
ACE_barrelLength=500.0;
L1A1 Polymer/Wood
ACE_barrelTwist = 302.26;
ACE_barrelLength =554.4;
MG42
ACE_barrelTwist = 305;
ACE_barrelLength =530;
MP44
ACE_barrelTwist = 240;
ACE_barrelLength =420;
M3A1
ACE_barrelTwist = 406;
ACE_barrelLength =203.2;
M1 Garand
ACE_barrelTwist = 254;
ACE_barrelLength =610;