Arsenal - Add Sorting Algorithms #7719
Conversation
BrettMayson
changed the title
|
The classnames shouldn't have used parentheses. |
|
Where? |
|
@jonpas WIP can be removed, this is ready for review |
|
yeah ready for review now, not WIP |
| @@ -0,0 +1,64 @@ | |||
| class GVAR(sorts) { | |||
There was a problem hiding this comment.
Is the scope entry and as a result the sortBase class necessary? I think its reasonable to have all sorting algorithms defined here be public.
Also, fix spaces after commas in this file.
There was a problem hiding this comment.
If we want to add properties in the future this class would be useful, it also keeps it inline with the rest of arsenal
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
BrettMayson
force-pushed
the
arsenal_sorting
branch
from
8f53dfb
to
a1a0bb0
Compare
|
There is still some areas that can be cleaned up, including the magic numbers. |
|
Ready for review, WIP can be removed |
BrettMayson
force-pushed
the
arsenal_sorting
branch
from
cc5defc
to
4818a38
Compare
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
changed the title
When merged this pull request will:
Theoretically this could support multiple sorting algorithms at once. Ex. Sort by fire rate, then sort by weight, then alphabetically. I can't think of a nice way to implement that on the UI side. It will however still sub sort alphabetically, Ex. Sort by fire rate, sort weapons with the same fire rate alphabetically.
Images
Old Alphabetical SortNotice how the
AK-15is separated from it's variants by the GL version.New Alphabetical Sort
