Cargo - Add ability to add custom name to cargo objects #8023

JasperRab · 2020-11-29T21:25:00Z

Ever had more than 5 of the same ammo boxes in a vehicle? And you need to find that one with your favorite banana?
Well with this you can change the name of the boxes that are loadable into the cargo system.

When merged this pull request will:

Add the ability to add a custom name to crates/boxes. Either via in-game action on the object it self, via 3den attributes or via a setVariable.

Pictures:

Cargo menu with custom names and default (some) names.

3den attribute where the custom name can be set by mission makers.

UI of the renaming interface.

Added the ability to edit cargo objects (crates/boxes only) names. Either via in-game action on the object it self or via 3den attributes. Added a single function which spawns the UI to edit the name and also edits it. This is an scripted UI, it could be changed to a config version if wanted, but as I'm not good in UI coding I left it on this simple version mainly for testing. Added 4 new stringtable entries, 2 for action and 2 for 3den attributes.

Forgot to add the UI to the stringtable.

fixing tabs

jonpas · 2020-11-29T21:33:44Z

I've added a single function which spawns the UI to edit the name and also edits it. This is an scripted UI, it could be changed to a config version if wanted, but as I'm not good in UI coding I left it on this simple version mainly for testing, and to test the idea.

Scripted UI is better, easier to work with.

These require extra translations.

Just leave them empty. Translators will translate (add their own languages) whenever they will.

However the game did not like it as it kept creating this from it:

QUOTE adds a double quote (") around text, anything inside a double quote is literal (macros will not get resolved. You can either use a single quote (') or another set of double quotes (eg. QQGVAR˙ does that). Depends what your GET_STRING` is.

jonpas · 2020-11-29T21:39:20Z

I don't particularly like another interaction menu node just for that. Why not put it into the cargo menu itself? Load and then rename.

I would also keep the base object name and add custom part to the end.

JasperRab · 2020-11-29T21:46:05Z

Well the issue we have in our unit is that we use crates a lot for rearming, and loading the crates in to just rename them feels like extra work, and an hindrance. Also we use different boxes for different ammo type, currently I've created multiple empty boxes with different names. However this option would give mission makers/logistic workers the freedom to do stuff their own way, not being limited to the names.
However if others think it would better fit in the cargo menu I could have a look at it.

I could add the custom tag to the end of the normal name, however I initially didn't want to add too much text as it could be annoying.

jonpas · 2020-11-29T22:01:07Z

and loading the crates in to just rename them feels like extra work

But it's only visible in the cargo menu anyways? I would understand if it would be displayed somewhere else.

As an alternative, Rename action could be a child of the Load action to decrease clutter.

Drofseh · 2020-11-29T22:06:47Z

I think a child action of Load would be good.

JasperRab · 2020-11-30T13:35:18Z

As an alternative, Rename action could be a child of the Load action to decrease clutter.

When adding it as a child action to Load it would mean that you can't edit the name when you can't load it (when far away from vehicle). As it won't be visible then. I'm not 100% happy about this compromise, I do agree less clutter is better but if it would mean the action won't be available all the time I'd leave it at the mainaction.

But it's only visible in the cargo menu anyways? I would understand if it would be displayed somewhere else.

True, but I prefer if it can be changed without needing to load an object, that way you can prepare a few crates for later.

jonpas · 2021-04-20T10:53:20Z

2 things I want for this:

Keep the base object name and add custom part to the end.
Setting to hide the "Rename" interaction, so people can hide it if they don't want to use it.

Added new function "getNameItem" that will get the items name. Put the custom name behind the original name between brackets "[...]".

Also removed an unused _itemClass from postInit.

JasperRab · 2021-04-24T10:20:32Z

I've changed it so that the custom part is behind the base name (see picture below).
Also I've added the setting to enable/disable the action (default is visible), this can be changed to hidden by default if wanted.

I also saw that there are some conflicting files, I tried to merge from the master to my branch but that hasn't resolved it.
How can I fix this?

jonpas

Fixed merge conflicts for you, some more styling suggestions.

addons/cargo/CfgEden.hpp

addons/cargo/functions/fnc_getNameItem.sqf

addons/cargo/functions/fnc_renameObject.sqf

Co-authored-by: jonpas <jonpas33@gmail.com>

Added my name

JasperRab · 2021-04-24T13:17:36Z

Just did a last test with your suggestions and the merge from master, all works as intended.
I've also added myself to the authors file.

jonpas

Somebody else look at the UI stuff.

addons/cargo/initSettings.sqf

addons/cargo/functions/fnc_renameObject.sqf

addons/cargo/XEH_postInit.sqf

addons/cargo/functions/fnc_getNameItem.sqf

addons/cargo/XEH_PREP.hpp

BrettMayson · 2021-06-28T19:38:38Z

Is the only holdout here the UI?

JasperRab · 2021-06-29T12:07:10Z

Is the only holdout here the UI?

As far as I know I've applied all the requested changes, if anything else needs to be changed be free to tell me.

jonpas · 2021-07-23T13:39:31Z

@mharis001 re-review please.

mharis001

If you click the background in the GUI the edit box loses focus and cannot be clicked into. Only way to go back into the edit box is by using TAB. Also, if the edit box is not in focus, you can move the player around with WASD (use a dialog to fix).

addons/cargo/stringtable.xml

addons/cargo/functions/fnc_getNameItem.sqf

addons/cargo/functions/fnc_renameObject.sqf

JasperRab · 2021-07-31T10:21:44Z

I've moved the UI to a config file so it can be used with createDialog.
New UI looks like this:

To make the UI I've taken the cargo menu as template and rebuild it with the correct sizes from there.
I've also rewritten the renameObject function as the UI stuff wasn't needed anymore.

Fixed tabs to spaces.

JasperRab · 2021-08-06T14:16:11Z

@mharis001 I've fixed/reworked the UI as stated in my last message, could you have another look at it?

BrettMayson · 2021-09-20T13:21:55Z

@JasperRab Can you fix the conflict?

JasperRab · 2021-09-20T16:50:58Z

@BrettMayson Done, wasn't aware about the conflict. so thanks for reminding.

addons/arsenal/ui/RscAttributes.hpp

mharis001

Dislike the use of ACE_gui_X GUI base classes over the base game's RscX. But, I guess that is an overall issue with the cargo component.

GUI works as expected now.

addons/cargo/functions/fnc_initObject.sqf

addons/cargo/functions/fnc_renameObject.sqf

* First Push Added the ability to edit cargo objects (crates/boxes only) names. Either via in-game action on the object it self or via 3den attributes. Added a single function which spawns the UI to edit the name and also edits it. This is an scripted UI, it could be changed to a config version if wanted, but as I'm not good in UI coding I left it on this simple version mainly for testing. Added 4 new stringtable entries, 2 for action and 2 for 3den attributes. * Add extra stringtable Forgot to add the UI to the stringtable. * Update fnc_renameObject.sqf fixing tabs * Show custom name only behind Added new function "getNameItem" that will get the items name. Put the custom name behind the original name between brackets "[...]". * Added "Hide Rename Action" setting Also removed an unused _itemClass from postInit. * Apply suggestions from code review Co-authored-by: jonpas <jonpas33@gmail.com> * Update AUTHORS.txt Added my name * Applied the sugesstions. * Fixed function crash * Moved to dialog. * Removed unused comment/code * Update renameMenu.hpp Fixed tabs to spaces. * Update renameMenu.hpp * move rename to common * Update addons/arsenal/ui/RscAttributes.hpp * style and use addActionToObject Co-authored-by: jonpas <jonpas33@gmail.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>

JasperRab added 3 commits November 29, 2020 21:28

Add extra stringtable

621052c

Forgot to add the UI to the stringtable.

Update fnc_renameObject.sqf

00f4427

fixing tabs

jonpas added the kind/added feature label Apr 20, 2021

jonpas added this to the 3.14.0 milestone Apr 20, 2021

jonpas added status/WIP status/discussion labels Apr 20, 2021

JasperRab added 3 commits April 24, 2021 11:41

Merge branch 'master' into cargo-rename

bf4b985

Show custom name only behind

dd086b2

Added new function "getNameItem" that will get the items name. Put the custom name behind the original name between brackets "[...]".

Added "Hide Rename Action" setting

f315a8b

Also removed an unused _itemClass from postInit.

Merge branch 'master' into cargo-rename

efcfaa4

jonpas requested changes Apr 24, 2021

View reviewed changes

JasperRab and others added 2 commits April 24, 2021 15:07

Apply suggestions from code review

6629151

Co-authored-by: jonpas <jonpas33@gmail.com>

Update AUTHORS.txt

5aab8c0

Added my name

jonpas modified the milestones: 3.14.1, 3.14.0 Apr 24, 2021

jonpas removed the status/WIP label Apr 24, 2021

jonpas approved these changes Apr 24, 2021

View reviewed changes

mharis001 requested changes Apr 25, 2021

View reviewed changes

JasperRab added 2 commits April 25, 2021 13:45

Applied the sugesstions.

fa9a301

Fixed function crash

94c2926

dedmen mentioned this pull request May 18, 2021

Named boxes ace cargo WolfCorps/WolfLogistics#1

Open

jonpas mentioned this pull request Jun 27, 2021

Cargo - Add name to bodybags #8297

Merged

jonpas requested a review from mharis001 July 23, 2021 13:39

mharis001 requested changes Jul 23, 2021

View reviewed changes

addons/cargo/stringtable.xml Outdated Show resolved Hide resolved

addons/cargo/stringtable.xml Outdated Show resolved Hide resolved

addons/cargo/functions/fnc_getNameItem.sqf Outdated Show resolved Hide resolved

addons/cargo/functions/fnc_renameObject.sqf Outdated Show resolved Hide resolved

JasperRab added 2 commits July 31, 2021 12:15

Moved to dialog.

84dd4c0

Removed unused comment/code

f276f23

Seb105 mentioned this pull request Aug 1, 2021

Utilise ACE Cargo Crate renaming CntoDev/compositions#197

Closed

Update renameMenu.hpp

9ad40cc

Fixed tabs to spaces.

Merge branch 'master' into cargo-rename

e5d0b80

PabstMirror added 3 commits October 12, 2021 14:57

Merge branch 'master' into pr/8023

2aed4df

Update renameMenu.hpp

3866e42

move rename to common

4a7e4db

jonpas requested changes Oct 12, 2021

View reviewed changes

addons/arsenal/ui/RscAttributes.hpp Outdated Show resolved Hide resolved

Update addons/arsenal/ui/RscAttributes.hpp

c6c4da0

jonpas approved these changes Oct 12, 2021

View reviewed changes

jonpas requested a review from mharis001 October 12, 2021 20:54

mharis001 approved these changes Oct 12, 2021

View reviewed changes

addons/cargo/functions/fnc_initObject.sqf Outdated Show resolved Hide resolved

addons/cargo/functions/fnc_renameObject.sqf Outdated Show resolved Hide resolved

style and use addActionToObject

4ec7fb1

PabstMirror mentioned this pull request Oct 12, 2021

Cargo - Rename feature followup #8507

Closed

PabstMirror merged commit 257d953 into acemod:master Oct 12, 2021

jonpas added kind/feature Release Notes: **ADDED:** and removed kind/added feature labels Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cargo - Add ability to add custom name to cargo objects #8023

Cargo - Add ability to add custom name to cargo objects #8023

JasperRab commented Nov 29, 2020 •

edited

Loading

jonpas commented Nov 29, 2020

jonpas commented Nov 29, 2020

JasperRab commented Nov 29, 2020 •

edited

Loading

jonpas commented Nov 29, 2020

Drofseh commented Nov 29, 2020

JasperRab commented Nov 30, 2020 •

edited

Loading

jonpas commented Apr 20, 2021

JasperRab commented Apr 24, 2021 •

edited

Loading

jonpas left a comment

JasperRab commented Apr 24, 2021 •

edited

Loading

jonpas left a comment

BrettMayson commented Jun 28, 2021

JasperRab commented Jun 29, 2021

jonpas commented Jul 23, 2021

mharis001 left a comment

JasperRab commented Jul 31, 2021

JasperRab commented Aug 6, 2021

BrettMayson commented Sep 20, 2021

JasperRab commented Sep 20, 2021

mharis001 left a comment

Cargo - Add ability to add custom name to cargo objects #8023

Cargo - Add ability to add custom name to cargo objects #8023

Conversation

JasperRab commented Nov 29, 2020 • edited Loading

jonpas commented Nov 29, 2020

jonpas commented Nov 29, 2020

JasperRab commented Nov 29, 2020 • edited Loading

jonpas commented Nov 29, 2020

Drofseh commented Nov 29, 2020

JasperRab commented Nov 30, 2020 • edited Loading

jonpas commented Apr 20, 2021

JasperRab commented Apr 24, 2021 • edited Loading

jonpas left a comment

Choose a reason for hiding this comment

JasperRab commented Apr 24, 2021 • edited Loading

jonpas left a comment

Choose a reason for hiding this comment

BrettMayson commented Jun 28, 2021

JasperRab commented Jun 29, 2021

jonpas commented Jul 23, 2021

mharis001 left a comment

Choose a reason for hiding this comment

JasperRab commented Jul 31, 2021

JasperRab commented Aug 6, 2021

BrettMayson commented Sep 20, 2021

JasperRab commented Sep 20, 2021

mharis001 left a comment

Choose a reason for hiding this comment

JasperRab commented Nov 29, 2020 •

edited

Loading

JasperRab commented Nov 29, 2020 •

edited

Loading

JasperRab commented Nov 30, 2020 •

edited

Loading

JasperRab commented Apr 24, 2021 •

edited

Loading

JasperRab commented Apr 24, 2021 •

edited

Loading