-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interact Menu - Add settings for self interaction menu reordering #8036
Conversation
Interesting! I am wondering if we really need the overall "Allow Reordering" setting, it seems to just add complexitiy. We could just generate all relevant settings on start, I don't see a real downside. |
I had 2 reasons:
Personally I don't care - please you decide. |
Maybe I wasn't clear enough or I don't know if I understood you. If I am reading this correctly, when user enables "Allow Reordering" setting and restarts the mission, user gets additional settings for additional actions "Move X to Root", "Move Y to Root", correct? I am not sure what @dedmen's concerns were (can you enlighten us @dedmen?), but if it's not a few seconds of delay, then I am fine with there being many settings. How many settings are there in total with all of ACE3 anyways? |
Additional setting categories
I have a delay about 1.2s on my PC when opening |
Is it that slow simply because there are 80 settings in there? You don't do anything on the fly, everything happens on the What about splitting that large menu into multiple smaller menus to make it faster? Maybe Equipment, Interaction, ..., Other? |
Yes.
There are many ACE categories in settings already. I don't think splitting this setting to submenu is cool. Also I think (at least from my experience) this setting is opened and used only once, so delay is not a real problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the delay is a problem either. As long as it isn't too long to trigger ACRE/TFAR disconnect.
I say we get rid of the "Allow Reordering" setting. @PabstMirror @BaerMitUmlaut @mharis001 (and others) What's your take on this?
I agree with @jonpas . I think the "Allow reordering" setting is not needed; these additional settings should always be available. I terms of performance, I didn't notice any delays other than the expected one when selecting the "Move to Root" settings category. Even that wasn't too bad - not longer than a second or so. |
That was checkboxes in game settings menu making texture lookups each. |
When merged this pull request will:
More
submenu to unit self interaction menu and settings to move any root menu items there;I often use self interaction menu. But some items I use very often and some ones rarely. E.g. I put earplugs in each time I enter static/vehicle weapon and put them out on exit (to hear better). On the other hand I use
Team management
only once during mission andCreate Zeus
once in several missions. I don't want to disableGestures
andCheck air temperature
but they are better for me inMore
submenu. So I would like to move earplugs to root and hide others inMore
submenu.All settings are disabled by default and require mission restart.
To use them:- Settings - ACE Interaction menu - ACE Interaction menu (Self) - Allow reordering;- restart mission;- Settings - ACE Interaction menu (Self) - More/Move to Root - check what you need;- restart mission.