Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interact Menu - Optimize interaction menu conditions #8037

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Interact Menu - Optimize interaction menu conditions #8037

merged 1 commit into from
Dec 17, 2020

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • remove useless true && { code from empy/true interaction conditions;
  • optimize fnc_compileMenuZeus a little.

Before:

        true && {
            [ACE_player, _target, ["isNotInside", "isNotSwimming", "isNotSitting"]] call ace_common_fnc_canInteractWith
        }

After:

        [ACE_player, _target, ["isNotInside", "isNotSwimming", "isNotSitting"]] call ace_common_fnc_canInteractWith

@Dystopian Dystopian changed the title Optimize interaction menu conditions Interact Menu - Optimize interaction menu conditions Dec 8, 2020
@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Dec 8, 2020
@PabstMirror PabstMirror added this to the 3.13.6 milestone Dec 8, 2020
PabstMirror
PabstMirror approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍

@commy2 commy2 merged commit 50f740f into acemod:master Dec 17, 2020
@Dystopian Dystopian deleted the fix-interact-condition branch December 17, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Dystopian @PabstMirror @commy2