-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interaction - Add interaction with terrain objects #8103
Interaction - Add interaction with terrain objects #8103
Conversation
What happens when terrain object is a large building and somebody is inside it? Even on small objects, any chance for offsets, blowing things up inadvertendly etc.? |
The largest "building" I tested and implemented is
There is a small chance of objects colliding. At least I saw plastic chairs falling to ground when replaced. But I don't think it's a big issue. And also the setting is disabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's pretty neat then!
Co-authored-by: jonpas <jonpas33@gmail.com>
Co-authored-by: jonpas <jonpas33@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little rough because of physX.
On stratis beach the "sun chairs" went flying into the ocean because of collisions.
note: I forgot to test, but maybe adding a frame delay between hide and create would help?
but it also adds a lot of functionality, it is default off and the setting has a warning, so I think it's ok to merge
I am good to merge this. Regarding physics issues:
|
* Add interaction with terrain objects * Optimize with new commands * Handle z-position under ground * Add warning for setting * Add parentheses to condition Co-authored-by: jonpas <jonpas33@gmail.com> * Add comments * Add parentheses to condition Co-authored-by: jonpas <jonpas33@gmail.com> * Add parentheses to condition Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com> * Add replacement configs to dragging This reverts commit afc5abe. * Fix validator error and optimize condition Co-authored-by: jonpas <jonpas33@gmail.com> Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
When merged this pull request will:
Terrain objects with
ace_interaction_replaceTerrainObject
config value == 1 are replaced with created object when interaction menu is being opened near them. This feature can be useful at least fordragging
,acex sitting
andacex field_rations
.