Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction - Show all possible modes for an attachment #8154

Merged
merged 6 commits into from
Jul 27, 2024
Merged

Interaction - Show all possible modes for an attachment #8154

merged 6 commits into from
Jul 27, 2024

Conversation

PabstMirror
Copy link
Contributor

image

@PabstMirror PabstMirror added this to the 3.14.0 milestone Mar 7, 2021
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Mar 7, 2021
@Dystopian
Copy link
Contributor

Tested, works. I would suggest to move these actions from Detach submenu to between Attach and Detach actions. It's much easier to select actions this way at least when menu is in list mode.

@mjc4wilton
Copy link
Contributor

Tested, works. I would suggest to move these actions from Detach submenu to between Attach and Detach actions. It's much easier to select actions this way at least when menu is in list mode.

Maybe make it so it goes Weapon Attachments -> [Array of attachments] -> [Mode, Detach, etc.]?

@PabstMirror PabstMirror changed the title Interaction - Show all possible modes for an attachement WIP: Interaction - Show all possible modes for an attachement Mar 8, 2021
@PabstMirror PabstMirror modified the milestones: 3.15.1, Ongoing May 24, 2022
@BrettMayson BrettMayson changed the title WIP: Interaction - Show all possible modes for an attachement Interaction - Show all possible modes for an attachement Oct 16, 2023
@BrettMayson BrettMayson marked this pull request as draft October 16, 2023 06:52
@johnb432 johnb432 changed the title Interaction - Show all possible modes for an attachement Interaction - Show all possible modes for an attachment Jul 20, 2024
@johnb432
Copy link
Contributor

johnb432 commented Jul 20, 2024 •
edited
Loading

Maybe make it so it goes Weapon Attachments -> [Array of attachments] -> [Mode, Detach, etc.]?

I fully agree with that, given we're adding some new actions. I went ahead and pushed the necessary changes.

I've addressed the PIP scopes issue.

@johnb432 johnb432 marked this pull request as ready for review July 20, 2024 13:37
@johnb432 johnb432 modified the milestones: Ongoing, 3.18.0 Jul 20, 2024
johnb432
johnb432 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but given I've rewritten part of the code, I'd like another person to take a second look at this.

@PabstMirror PabstMirror mentioned this pull request Jul 21, 2024
Merged
@PabstMirror
Copy link
Contributor Author

image

IMHO this might helpreadability to make the detach/attach sub-actions simpler
so they stand out from the switch action?

instead of SPIR -> Detach: SPIR
now just SPIR -> Detach

@johnb432
Copy link
Contributor

johnb432 commented Jul 22, 2024 •
edited
Loading

IMHO this might helpreadability to make the detach/attach sub-actions simpler so they stand out from the switch action?

instead of SPIR -> Detach: SPIR now just SPIR -> Detach

Done for both attach and detach.

@johnb432 johnb432 merged commit e3d8f40 into master Jul 27, 2024
5 checks passed
@johnb432 johnb432 deleted the weaponAttachmentToggleMode branch July 27, 2024 17:37
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@PabstMirror @johnb432 @blake8090
Interaction - Show all possible modes for an attachment (acemod#8154)
86585a9 
* Interaction - Show all possible modes for an attachement

* Move attach & detach actions under item action

* Remove switching from PIP to regular 2D

* Remove attachment name from attach/detach actions

* Fixed typo in variable name

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dystopian Dystopian Dystopian requested changes

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @Dystopian @mjc4wilton @johnb432