Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interact Menu - Simplify fnc_renderActionPoints #8186

Merged
merged 2 commits into from
Jul 24, 2021

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • title.

To understand how inline function _fnc_renderNearbyActions works I had to simplify it a little. Changes:

  • use continue to decrease loop nesting depth;
  • replace _numInteractions (int) with _hasInteractions (bool) because number is not used;
  • fix _classActions = _namespace getVariable typeOf _target doesn't have default value;
  • some small code optimizations.

It's better to view changes in IDE than here in GitHub.

@jonpas jonpas added this to the 3.13.7 milestone Apr 20, 2021
@jonpas jonpas requested a review from PabstMirror April 20, 2021 09:52
@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** kind/optimization Release Notes: **IMPROVED:** labels Apr 20, 2021
@PabstMirror PabstMirror merged commit 27bd25c into acemod:master Jul 24, 2021
@Dystopian Dystopian deleted the optimize-renderActionPoints branch July 24, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants