Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAGR - Align underlining in waypoint editing page #8313

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

LupusTheCanine
Copy link
Contributor

@LupusTheCanine LupusTheCanine commented Jul 10, 2021

When merged this pull request will:

I simply took 2nd and 7th underlines as they are aligned with 1st and 8th digit respectively and recalculated x values based on these. It is not perfect but definitely good enough.
image

@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Jul 10, 2021
@jonpas jonpas added this to the 3.14.0 milestone Jul 10, 2021
@BaerMitUmlaut BaerMitUmlaut changed the title Align underlining in DAGR way-point editing page DAGR - Align underlining in waypoint editing page Jul 21, 2021
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but I don't use the DAGR.

@PabstMirror
Copy link
Contributor

PabstMirror commented Jul 23, 2021

it was still a little off at 1280x1024xsmall
image
it might be a non-monospaced font or ui scaling issue (5x4 is rare)

but overall a big improvement from master, so I think it's good for now

@PabstMirror PabstMirror merged commit 4ae4dba into acemod:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digits are underlined incorrectly in DAGR waypoint input window
3 participants