Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical GUI - Change hemorrhage text colors #8354

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

severgun
Copy link
Contributor

@severgun severgun commented Aug 5, 2021

When merged this pull request will:

  • Change hemorrhage text color from always red to yellow-red grade.

There was feature request to change Lost some blood text color from red to white. I think yellow is better to show that there is some loss but not so "screaming" as red.

https://gka.github.io/palettes/#/4|s|ffff00,ff0000|ffffe0,ff005e,93003a|0|0

#ffff00
#ffaa00
#ff5500
#ff0000

From red to yellow-red grade.
@severgun severgun changed the title Change hemorrhage text colors Medical GUI - Change hemorrhage text colors Aug 5, 2021
@jonpas jonpas added this to the 3.14.0 milestone Aug 6, 2021
@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Aug 6, 2021
@severgun
Copy link
Contributor Author

severgun commented Aug 7, 2021

Or should I take colors from #8350 ?
For example 3, 5, 7, 9

@jonpas
Copy link
Member

jonpas commented Oct 10, 2021

Using colors from #8350 sounds like a good idea to me. But I don't think it's that important, how is the visibility of this way vs. using #8350 colors? Different places might prefer slightly different shades for good visibility.

@PabstMirror PabstMirror merged commit 24c1861 into acemod:master Oct 13, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
From red to yellow-red grade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants