Interact Menu - Add inheritance support to removeActionFromClass #8396
Conversation
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
…m/Salluci/ACE3 into removeActionFromClass-inheritance
|
Should it be excludeClasses or excludedClasses? |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
|
Do we still care about this? |
|
Even if ACE doesn't, someone will. |
I do, as I have a mod that could make use of it. Hoping it gets added. |
|
@LinkIsGrim status on this? |
|
It works (or it did last time I touched it, and there's been no updates to this part of the code). Needs reviewing. |
|
I guess that was to take into account actions added to |
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
There was a problem hiding this comment.
@johnb432's changes LGTM.
Note, this PR is a performance degradation whenever an object is created due to the additional checks, but there's no getting around that if we want this feature.
…mod#8396) * Add inheritance & exclusion support * Update documentation in wiki * additional check for parent class in findIf * forEach instead of count Co-authored-by: PabstMirror <pabstmirror@gmail.com> * condition for children of excluded classes * touch everything but the params check * apply configName in same line * fix param data type for _excludedClasses Co-authored-by: PabstMirror <pabstmirror@gmail.com> * Update addons/interact_menu/functions/fnc_removeActionFromClass.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Fix & formatting * Fix missing _x & headers, remove invalid classes --------- Co-authored-by: Salluci <69561145+Salluci@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
When merged this pull request will: