Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Optimize fnc_getClaimObjects #8459

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Sep 30, 2021

When merged this pull request will:

  • Title.

Before:

Result:
0.199402 ms

Cycles:
5015/10000

Code:
[player, 15, [["Ace_Track", "ACE_track"]]] call ace_repair_fnc_getClaimObjects

After:

Result:
0.0299 ms

Cycles:
10000/10000

Code:
[player, 15, [["Ace_Track", "ACE_track"]]] call ace_repair_fnc_getClaimObjects

Majority of speedup comes from checking if object has been claimed via variable instead of canInteractWith, but still did some code cleanup.

@jonpas jonpas added kind/optimization Release Notes: **IMPROVED:** status/WIP labels Sep 30, 2021
@LinkIsGrim LinkIsGrim marked this pull request as ready for review September 30, 2021 16:47
@PabstMirror PabstMirror added this to the 3.14.0 milestone Oct 11, 2021
@jonpas jonpas changed the title Repair - Optimize fnc_getClaimObjects Repair - Optimize fnc_getClaimObjects Oct 12, 2021
@PabstMirror PabstMirror merged commit 82f705b into acemod:master Oct 12, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants