Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Fix claimed object abuse #8460

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Sep 30, 2021

When merged this pull request will:

  • Remove ability to use claimed objects in multiple repairs.

Fix for the "wheel glitch" which lets two or more players repair multiple hitpoints with a single spare wheel/track.
Only takes exisiting repair options into account. Third party additions using callbackProgress will have to reimplement this.

@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Sep 30, 2021
@jonpas jonpas added this to the 3.14.0 milestone Sep 30, 2021
@jonpas
Copy link
Member

jonpas commented Oct 10, 2021

Do we know of any 3rd party that uses callbackProgress that we can notify?

@LinkIsGrim
Copy link
Contributor Author

Personally I don't even know of any 3rd party using Repair's API.

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's merge!

@jonpas jonpas merged commit 9479c29 into acemod:master Oct 10, 2021
@jonpas jonpas mentioned this pull request Nov 2, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants