Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach - Follow bone rotation for attached items #8477

Merged
merged 2 commits into from
Oct 10, 2021

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Oct 3, 2021

Before:

XR04Zrfycx.mp4

After:

RWuWZ2UWg6.mp4

The offset ACE sets is a bit weird now.

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Oct 3, 2021
@jonpas jonpas added this to the 3.14.0 milestone Oct 3, 2021
@dedmen
Copy link
Contributor Author

dedmen commented Oct 3, 2021

Should adjust the offset too.
Old:
Arma3Retail_DX11_x64_uD1865414h

New:

Arma3Retail_DX11_x64_d2ayiHYySS

@dedmen
Copy link
Contributor Author

dedmen commented Oct 3, 2021

0.07, -0.06, 0.085
Arma3Retail_DX11_x64_2hI17yLmhn
Arma3Retail_DX11_x64_fhZtZKEAyq
Arma3Retail_DX11_x64_hxDMdWQmYt

Looks good I'd say, except of course my GPS tracker but... well.

Could theoretically setVectorDirAndUp for rotation offset so you really attach it to the backpack strap but can't really be bothered, the old code also didn't bother with that.

@jonpas jonpas changed the title Follow bone rotation for attached items Attach - Follow bone rotation for attached items Oct 10, 2021
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jonpas jonpas merged commit 7bf9f31 into acemod:master Oct 10, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants