Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towing - Fix you can still tow wreck even if you shouldn't #8536

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Towing - Fix you can still tow wreck even if you shouldn't #8536

merged 1 commit into from
Oct 16, 2021

Conversation

Vdauphin
Copy link
Contributor

You can still try to attach rope on wreck which you shouldn't be allow according to the current implementation

When merged this pull request will:

  • Little typo: _target is not define
  • Change _target to _parent

@jonpas jonpas added this to the 3.14.0 milestone Oct 16, 2021
@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Oct 16, 2021
@Dabako
Copy link
Contributor

Dabako commented Oct 16, 2021

Okay, but I think an implementation to have the ability to move wrecks in some way would also be really nice in the future.

TheCandianVendingMachine
TheCandianVendingMachine approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should be able to tow wrecks, but that can come later (and I don't know if it is supported via setTowParent)

@PabstMirror PabstMirror merged commit 5fc9856 into acemod:master Oct 16, 2021
@Vdauphin Vdauphin deleted the patch-6 branch October 17, 2021 08:53
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
@Vdauphin @AndreasBrostrom
FIX: _target not define (acemod#8536)
444d291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCandianVendingMachine TheCandianVendingMachine TheCandianVendingMachine approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Vdauphin @Dabako @TheCandianVendingMachine @jonpas @PabstMirror