Advanced Ballistics - Fix _maxRange in handleFired
#8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
changed the title
handleFired_maxRange in handleFired
mharis001
approved these changes
Oct 18, 2021
|
Because these distance checks never worked, I am worried by enabling them now it could make things worse |
mharis001
approved these changes
Oct 25, 2021
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
* AdvBallistics - Fix _maxRange in `handleFired` * Adding 30% more to range just to be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_vanillaInitialSpeedwas never defined so_maxRangewas always nilinner
_maxRangewas private, (would be nil only on first run, afterwords it would use the getVar)the only effect these had was the exitWith would always fail
ACE3/addons/advanced_ballistics/functions/fnc_handleFired.sqf
Line 43 in dc6ce6a
I was getting range of about 1000 for a sniper rifle which almost seem a little low?