Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cook Off - Re-add setting to enable cookoff for player vehicles only #8611

Merged

Conversation

TheCandianVendingMachine
Copy link
Contributor

Fix #8575
Ripped from #7147 so it should work as expected

@TheCandianVendingMachine TheCandianVendingMachine added the kind/bug-fix Release Notes: **FIXED:** label Oct 24, 2021
@TheCandianVendingMachine TheCandianVendingMachine added this to the 3.14.1 milestone Oct 24, 2021
@jonpas jonpas changed the title Re-add setting to enable cookoff for player vehicles only Cook Off - Re-add setting to enable cookoff for player vehicles only Oct 24, 2021
@PabstMirror PabstMirror merged commit e7d0878 into acemod:master Oct 27, 2021
@veteran29
Copy link
Member

veteran29 commented Oct 29, 2021

Ripped from #7147 so it should work as expected

It seems that the original PR was bugged so this one is bugged too 🙈

https://github.com/acemod/ACE3/pull/7147/files#diff-cddadfc0da5a271adaea2ae314a10b78b96bab1258f9272eda09dc391d85156bR28

"If setting set to 2 (Players and AI) and no players in vehicle then exit"

It should check if the setting is set to 1 (Players only).

AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACE_cookoff_enable setting not working correctly
3 participants