Cookoff - Limit maximum cook intensity/duration #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would probably be better to scale the amount of intensity decrease depending on current intensity, the bigger intensity the faster it should scale down, this is a bandaid solution but if there will be no better implementation for the hotfix I think it makes sense to use this. |
|
we could also just do this without the changes to |
PabstMirror
approved these changes
Nov 7, 2021
jonpas
approved these changes
Nov 11, 2021
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Reasoning:
Advanced vehicle damage calculates the intensity (which indirectly also means duration) of the cook-off by getting the amount of the explosive ammo. This can result in ridiculously long cook-offs for vehicles that have autocannons with HE ammunition.
I've decided to use 10 intensity as maximum which roughly should limit it to ~7.5min (the intervals between cook-offs are randomised).
We could consider making this a setting but I'm not sure how to properly tell the user what it does.
Reproduction of the issue:
O_APC_Tracked_02_cannon_F