SOG Compat - Add isDamageAllowed check to punji damage handler
#8670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title. Previously, even units with damage disabled would still have wounds added upon triggering punji traps.
commy2
reviewed
Nov 7, 2021
Co-authored-by: commy2 <commy-2@gmx.de>
|
Could use the new parameter introduced in #8599 instead of the filter. |
|
right now 8599 throws an |
PabstMirror
approved these changes
Nov 7, 2021
jonpas
changed the title
isDamageAllowed check to punji damage handler
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
…mod#8670) * SOG Compat - Exclude invulnerable units from punji damage handler Title. Previously, even units with damage disabled would still have wounds added upon triggering punji traps. * Implement lazy select Co-authored-by: commy2 <commy-2@gmx.de> Co-authored-by: commy2 <commy-2@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: