-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo - Add alternative unloading item from vehicle cargo #8827
Conversation
Duplicate?🤔 #8797 |
If player cannot carry unloaded object, it will be placed randomly. My solution is for big (not-carried) objects and prevents collision bugs after unloading. |
What needs to be finished or looked at for this to be pulled? |
Nothing, I think. commy2 didn't respond me |
General testing, MP, and code review. |
I've taken the liberty to implement some fixes and improvements directly:
I have tested this both in SP and self-hosted MP, works in both cases. My suggestion is to merge #9617 first (if it's accepted), then this PR could be updated to accommodate the changes. |
Thx, @johnb432 ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than comment above
I've removed hiding the object when deployment is blocked since it's less confusing that way IMO. Tweaked object radius to use firegeometry bounding box as that's closer to the real thing. You can place objects inside other objects up to a certain point. If we want to prevent that, the intersection checks need to be changed to |
Also fixed menu staying open in death
You'll need to run that by me again chief, I don't get it. |
Math |
I went ahead and simplified the deployment method, by essentially copying what carrying does. I feel it's more robust and allows for greater flexibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When merged this pull request will:
YouTube presentation:
Open/close
.