Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW - Fix missing magazine on assembling #8880

Merged
merged 4 commits into from
May 4, 2022

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • fix missing magazine on assembling some launchers (I know only about CUP Metis);
  • fix fnc_reload_getVehicleMagazine header arguments.

When you place loaded with rocket CUP Metis to its internal tripod (you don't need an external one) it's assembled but without rocket in it. Rocket is just disappeared from your inventory. Also when you disassemble static Metis to portable launcher it's empty and rocket(s) is placed near you. This PR makes new launcher loaded if it was loaded before (dis)assembling.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for splendid-khapse-142a9c canceled.

Name Link
🔨 Latest commit a7dd2ab
🔍 Latest deploy log https://app.netlify.com/sites/splendid-khapse-142a9c/deploys/625fe4edb347de000860641f

@PabstMirror PabstMirror added this to the 3.14.2 milestone May 2, 2022
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label May 2, 2022
@PabstMirror
Copy link
Contributor

Works great on the cup metis

It seems like it's hardcoded to 1 round which is just fine for rockets,
in the future we could adjust it to handle belts with variable ammo
but I think this PR is fine as is

@PabstMirror PabstMirror merged commit 89badcc into acemod:master May 4, 2022
@Dystopian Dystopian deleted the fix_metis_csw branch May 5, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants