Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Vitals - Add event to vitals loop #8891

Merged
merged 3 commits into from
May 3, 2022
Merged

Medical Vitals - Add event to vitals loop #8891

merged 3 commits into from
May 3, 2022

Conversation

pterolatypus
Copy link
Contributor

@pterolatypus pterolatypus commented Apr 24, 2022 •
edited
Loading

When merged this pull request will:

  • Add a local event in the main vitals loop so that extension mods can run updates in-sync without having to write their own loop.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@mharis001 mharis001 assigned mharis001 and unassigned mharis001 Apr 24, 2022
@pterolatypus
Copy link
Contributor Author

pterolatypus commented May 1, 2022 •
edited
Loading

I feel like this should be documented, but I'm not sure where to put it as there isn't really any doc for vitals yet. Any ideas?

@PabstMirror PabstMirror added this to the 3.14.2 milestone May 2, 2022
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 2, 2022
@jonpas
Copy link
Member

jonpas commented May 3, 2022

@pterolatypus Can put it on the Events page, where there is a list of API events.

@PabstMirror PabstMirror merged commit 67842a2 into acemod:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pterolatypus @jonpas @PabstMirror @mharis001